Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 29 Jul 2014 02:31:29 +0000 (UTC)
From:      Ian Lepore <ian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r269206 - head/sys/arm/arm
Message-ID:  <201407290231.s6T2VTSp071604@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: ian
Date: Tue Jul 29 02:31:29 2014
New Revision: 269206
URL: http://svnweb.freebsd.org/changeset/base/269206

Log:
  Rename _bus_dma_can_bounce(), add new inline routines.
  
  DMA on arm can bounce for several reasons, and _bus_dma_can_bounce() only
  checks for the lowaddr/highaddr exclusion ranges in the dma tag, so now
  it's named exclusion_bounce().  The other reasons for bouncing are checked
  by the new functions alignment_bounce() and cacheline_bounce().
  
  Reviewed by:	cognet

Modified:
  head/sys/arm/arm/busdma_machdep-v6.c

Modified: head/sys/arm/arm/busdma_machdep-v6.c
==============================================================================
--- head/sys/arm/arm/busdma_machdep-v6.c	Tue Jul 29 01:46:31 2014	(r269205)
+++ head/sys/arm/arm/busdma_machdep-v6.c	Tue Jul 29 02:31:29 2014	(r269206)
@@ -241,8 +241,8 @@ SYSINIT(busdma, SI_SUB_KMEM, SI_ORDER_FO
  * possibly have RAM at an address higher than the highest address we can
  * express, so we take a fast out.
  */
-static __inline int
-_bus_dma_can_bounce(vm_offset_t lowaddr, vm_offset_t highaddr)
+static int
+exclusion_bounce(vm_offset_t lowaddr, vm_offset_t highaddr)
 {
 	int i;
 
@@ -258,6 +258,26 @@ _bus_dma_can_bounce(vm_offset_t lowaddr,
 	return (0);
 }
 
+/*
+ * Return true if the given address does not fall on the alignment boundary.
+ */
+static __inline int
+alignment_bounce(bus_dma_tag_t dmat, bus_addr_t addr)
+{
+
+	return (addr & (dmat->alignment - 1));
+}
+
+/*
+ * Return true if the buffer start or end does not fall on a cacheline boundary.
+ */
+static __inline int
+cacheline_bounce(bus_addr_t addr, bus_size_t size)
+{
+
+	return ((addr | size) & arm_dcache_align_mask);
+}
+
 static __inline struct arm32_dma_range *
 _bus_dma_inrange(struct arm32_dma_range *ranges, int nranges,
     bus_addr_t curaddr)
@@ -291,9 +311,8 @@ run_filter(bus_dma_tag_t dmat, bus_addr_
 
 	do {
 		if (((paddr > dmat->lowaddr && paddr <= dmat->highaddr)
-		 || ((paddr & (dmat->alignment - 1)) != 0) ||
-		 (!coherent && (size & arm_dcache_align_mask)) ||
-		 (!coherent && (paddr & arm_dcache_align_mask)))
+		 || alignment_bounce(dmat, paddr) ||
+		 (!coherent && cacheline_bounce(paddr, size)))
 		 && (dmat->filter == NULL
 		  || (*dmat->filter)(dmat->filterarg, paddr) != 0))
 			retval = 1;
@@ -438,8 +457,8 @@ bus_dma_tag_create(bus_dma_tag_t parent,
 			atomic_add_int(&parent->ref_count, 1);
 	}
 
-	if (_bus_dma_can_bounce(newtag->lowaddr, newtag->highaddr)
-	 || newtag->alignment > 1)
+	if (exclusion_bounce(newtag->lowaddr, newtag->highaddr)
+	 || alignment_bounce(newtag, 1))
 		newtag->flags |= BUS_DMA_COULD_BOUNCE;
 
 	/*
@@ -718,7 +737,7 @@ bus_dmamem_alloc(bus_dma_tag_t dmat, voi
 	 * constraints is something that only the contig allocator can fulfill.
 	 */
 	if (bufzone != NULL && dmat->alignment <= bufzone->size &&
-	    !_bus_dma_can_bounce(dmat->lowaddr, dmat->highaddr)) {
+	    !exclusion_bounce(dmat->lowaddr, dmat->highaddr)) {
 		*vaddr = uma_zalloc(bufzone->umazone, mflags);
 	} else if (dmat->nsegments >= btoc(dmat->maxsize) &&
 	    dmat->alignment <= PAGE_SIZE && dmat->boundary == 0) {
@@ -765,7 +784,7 @@ bus_dmamem_free(bus_dma_tag_t dmat, void
 	bufzone = busdma_bufalloc_findzone(ba, dmat->maxsize);
 
 	if (bufzone != NULL && dmat->alignment <= bufzone->size &&
-	    !_bus_dma_can_bounce(dmat->lowaddr, dmat->highaddr))
+	    !exclusion_bounce(dmat->lowaddr, dmat->highaddr))
 		uma_zfree(bufzone->umazone, vaddr);
 	else
 		kmem_free(kernel_arena, (vm_offset_t)vaddr, dmat->maxsize);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201407290231.s6T2VTSp071604>