Date: Thu, 12 Apr 2018 22:01:48 +0200 From: Matthias Fechner <idefix@fechner.net> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467193 - in head/www/gitlab: . files Message-ID: <e1a55c7b-1ad1-36c8-ec3d-f806702feed5@fechner.net> In-Reply-To: <201804121833.w3CIXtgW077267@repo.freebsd.org> References: <201804121833.w3CIXtgW077267@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dear sunpoet, Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: > Log: > Fix Gemfile for rubygem-default_value_for 3.1.0 update > =20 > - Bump PORTREVISION for package change > > Modified: > head/www/gitlab/Makefile > head/www/gitlab/files/patch-Gemfile I really enjoy your work and it is totally fine for me, if you upgrade a gem that you copy the old one and make sure that gitlab uses the old. (like you did with r467106, thanks a lot for this!) But please do not start to patch the Gemfile! This will break gitlab. Have you tested gitlab with this modification? (for sure not, I reported exactly that version of default_value_for upstream and they rolled back the change as it broke gitlab, they broke 3.0.4 and rolled back the modification with 3.0.5, now you changed gitlab to use the version that for sure will not work!) Please revert this modification and ask me (the maintainer) before you start to modify the port I maintain. Thanks a lot that you understand this. Gru=C3=9F Matthias --=20 "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e1a55c7b-1ad1-36c8-ec3d-f806702feed5>