Date: Mon, 18 Jul 2016 13:34:02 -0700 From: Maxim Sobolev <sobomax@freebsd.org> To: "Andrey V. Elsukov" <bu7cher@yandex.ru>, Michael Zhilin <mizhka@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302985 - head/sys/geom/label Message-ID: <CAH7qZfvkxy9LMTBLyuaS=D5h1_C1BHV00bLjHoktUvZV=2=XRg@mail.gmail.com> In-Reply-To: <e48b47f8-ee2e-eaa9-2563-997e37dac17b@yandex.ru> References: <201607180500.u6I501CX063743@repo.freebsd.org> <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> <CAH7qZftQg4TDyGC_kMPVcHpinK_Q_JvKZ-uQXzim16SOFnw%2BPQ@mail.gmail.com> <61cba001-2717-49ee-843e-5ed6d18fa17b@yandex.ru> <CAH7qZftq0V8bOXtYPMd_Lc0W8yBqg8AyuCzejcJAwrc%2BoBaofA@mail.gmail.com> <e48b47f8-ee2e-eaa9-2563-997e37dac17b@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey, would you mind leaving your comments in the phabricator so that the Mikhail (original contributor of the patch) could work on an improved version? You might be correct about the abs(), I've overlooked that, but the fs_fsize math is just copied over the previous code as far as I can tell. So if it worked with the strict comparison, it should also work with relaxed bound one. https://reviews.freebsd.org/D6208 Thanks! -Max On Mon, Jul 18, 2016 at 1:18 PM, Andrey V. Elsukov <bu7cher@yandex.ru> wrote: > On 18.07.16 22:37, Maxim Sobolev wrote: > > Well, this looks to me exactly what I am talking about. With this change > > we are only allowing underlying provider to be *slighly* bigger than the > > UFS size. So as I said it's pretty harmless to do so, or at least I > > So, this isn't true. > 1. You use abs() in the macro - it can be less or bigger. > 2. fs_fsize is size of frag blocks, so use it as divider looks incorrect. > > -- > WBR, Andrey V. Elsukov > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAH7qZfvkxy9LMTBLyuaS=D5h1_C1BHV00bLjHoktUvZV=2=XRg>