Date: Fri, 10 May 2019 23:57:35 -0500 From: Doug Moore <unkadoug@gmail.com> To: Cy Schubert <Cy.Schubert@cschubert.com>, Doug Moore <dougm@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347477 - head/sys/kern Message-ID: <a5861276-9954-9185-fa75-ee0df8c3576e@gmail.com> In-Reply-To: <201905110447.x4B4lqeh031565@slippy.cwsent.com> References: <201905110447.x4B4lqeh031565@slippy.cwsent.com>
index | next in thread | previous in thread | raw e-mail
With mentor approval, I commit r347469. I start getting email about jenkins failure to build for several architectures on account of the _Generic() construct I introduced in that change. I whip up a patch to undo that part of r347469, and ask for mentor approval. Meanwhile, mentor authorizes me in email to revert r347469. I try apply applying the fix-patch, and get email that it was rejected for lack of reviewer. In retrospect, it seems to have been committed anyway as r347472. Thinking that things are still broken, I do what my mentor pre-approved earlier and revert back to before r347469. A patch to redo r347469, without _Generic(), awaits mentor approval. I realize that breaking the build and then committing without mentor approval in my first week as committer isn't a good beginning. Sorry about that. At least I have no social media presence, so there's that. Doug Moore On 5/10/19 11:47 PM, Cy Schubert wrote: > In message <201905110213.x4B2Dq9U088622@repo.freebsd.org>, Doug Moore > writes: >> Author: dougm >> Date: Sat May 11 02:13:52 2019 >> New Revision: 347477 >> URL: https://svnweb.freebsd.org/changeset/base/347477 >> >> Log: >> Revert r347469. > Why? > >> >> Approved by: kib (mentor) >> >> Modified: >> head/sys/kern/subr_blist.c >> >help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a5861276-9954-9185-fa75-ee0df8c3576e>