Date: Thu, 12 Apr 2018 13:11:46 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net>, "Simon J. Gerraty" <sjg@juniper.net> Cc: freebsd-current@freebsd.org Subject: Re: Module compiles looking in /usr/src when alternate src tree is in use Message-ID: <115747a8-a7f9-9112-d7b0-c4fc24742708@FreeBSD.org> In-Reply-To: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net> References: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--YRObYu5yywffVd7jj8ArloTsFLF5dYhhO
Content-Type: multipart/mixed; boundary="ydutFZf1TmORBrV6Js8x68RbBmJQBegYC";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net>,
"Simon J. Gerraty" <sjg@juniper.net>
Cc: freebsd-current@freebsd.org
Message-ID: <115747a8-a7f9-9112-d7b0-c4fc24742708@FreeBSD.org>
Subject: Re: Module compiles looking in /usr/src when alternate src tree is in
use
References: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net>
--ydutFZf1TmORBrV6Js8x68RbBmJQBegYC
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 4/10/2018 5:29 PM, Rodney W. Grimes wrote:
>> Rodney W. Grimes <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> wrote:
>>
>>> I am having a compile time issue for a patched that compiled fine on =
my
>>> r329294 system, but now failes to compile with what looks like a wron=
g
>>> header being included.
>>
>> You may find it helpful to do something like:
>>
>> make -dv -C sys/modules/vmm -V CFLAGS > /tmp/dvo 2>&1
>> egrep ':.PARSE|/usr/src/sys' /tmp/dvo | grep -B1 usr/src | more
>>
>> The arg to -V doesn't matter btw.
>> You could narrow that down if you know what var -I/usr/src/sys is in
>> (probably CFLAGS but you never know)
>> the above should help find the makefile that is introducing the bogus =
-I
>>
>=20
> Thank you, that does help narrow it down: (I backed up a vew lines
> from the first place I saw src/.)
>=20
> ...
> Global:.PARSEFILE =3D bsd.kmod.mk
> Global:.PARSEDIR =3D /usr/src-topo/share/mk
> Global:.PARSEFILE =3D bsd.kmod.mk
> Result[] of :U is "/usr/src/sys"
> Result[] of :U is "/usr/src/sys"
> Global:SYSDIR =3D ${:U/usr/src/sys:tA}
> Global:.PARSEDIR =3D /usr/src-topo/share/mk
> Global:.PARSEFILE =3D bsd.kmod.mk
> Result[] of :U is "/usr/src/sys"
> Applying[] :t to "/usr/src/sys"
> Result[] of :t is "/usr/src/sys"
> Result[] of :U is "/usr/src/sys"
> Applying[] :t to "/usr/src/sys"
> Result[] of :t is "/usr/src/sys"
> Result[] of :U is "/usr/src/sys"
> Applying[] :t to "/usr/src/sys"
> Result[] of :t is "/usr/src/sys"
> Global:.MAKE.MAKEFILES =3D /usr/src-topo/share/mk/sys.mk /usr/src-topo/=
share/mk/local.sys.env.mk /usr/src-topo/share/mk/src.sys.env.mk /usr/src-=
topo/share/mk/bsd.mkopt.m
> k /usr/src-topo/share/mk/src.sys.obj.mk /usr/src-topo/share/mk/auto.obj=
=2Emk /usr/src-topo/share/mk/bsd.suffixes.mk /usr/src-topo/share/mk/local=
=2Esys.mk /usr/src-topo/sha
> re/mk/src.sys.mk /usr/src-topo/sys/modules/vmm/Makefile /usr/src-topo/s=
hare/mk/bsd.kmod.mk /usr/src/sys/conf/kmod.mk
> =
^^^^^^^^^^^^^^^^^^^^^^^^^
> Thats gona bust something some day....
>=20
> Global:.PARSEDIR =3D /usr/src/sys/conf
> Global:.PARSEFILE =3D kmod.mk
> Global:.INCLUDEDFROMDIR =3D /usr/src/sys/conf
> Oh my! Uggggg
>=20
>=20
> So something in bsd.kmod.mk is going very wrong... it looks like it
> starts to pull all sorts of stuff from /usr/src/sys!
>=20
>>>
>>> I have wrapped the long line so I can point to a difference between
>>> r329294 and r332262 make log of this file.
>>>
>>> r329294 make output:
>>>
>>> cc -O2 -pipe -DVMM_KEEP_STATS -DSMP -fno-strict-aliasing -Werror -D=
_KERNEL \
>>> -DKLD_MODULE -nostdinc -I/usr/src-topo/sys/amd64/vmm \
>>> -I/usr/src-topo/sys/amd64/vmm/io -I/usr/src-topo/sys/amd64/vmm/intel =
\
>>> -I/usr/src-topo/sys/amd64/vmm/amd -I. -I/usr/src-topo/sys -fno-common=
\
>>> ^^^^^^^^^^^^^^^^^ this is what=
I would expect
>>
>>
>=20
Is this buildkernel or a direct module directory build?
Does reverting r331683 and r331682 help? Perhaps I missed ensuring
SYSDIR is exported properly.
--=20
Regards,
Bryan Drewery
--ydutFZf1TmORBrV6Js8x68RbBmJQBegYC--
--YRObYu5yywffVd7jj8ArloTsFLF5dYhhO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJaz72CAAoJEDXXcbtuRpfPqngIAMyPWuGDpt0bNrYu4oe8i+dg
FHzod2mmtp/wDm6OTHnitXvEhk2j1Qv2gx7nTc0EZzuV7LfGi0sgJ3H7bsncKH/b
DOOVPrClxr/6aCG7EDGE+IK3OjpHW9OXkmp1kmsk58WIbJHr2JCqCwh5qhulxwFK
5EaeqLmrzBDyvuubfxPqhRWjdd7fjdKD1y0wG13mUHkDHgCZXhAtmjpl/5DfOrqF
W3dJCX1ChjFVVIzkokng0mxKEHEadyEHcvS54ytbquoRBdfW54W1zRhFrKB2GPPq
mznrApCiH1DyQLGSEYZwInynI0VxVS3mdiByguwBoi01ehb+0CgrJBA5mNszQ1A=
=f4Hx
-----END PGP SIGNATURE-----
--YRObYu5yywffVd7jj8ArloTsFLF5dYhhO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?115747a8-a7f9-9112-d7b0-c4fc24742708>