Date: Tue, 27 Oct 2009 15:42:13 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: mav@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r198487 - head/sys/dev/ata Message-ID: <20091027.154213.1640491474.imp@bsdimp.com> In-Reply-To: <4AE76611.4030104@FreeBSD.org> References: <200910261123.n9QBNfJY087028@svn.freebsd.org> <20091027.150719.-1219478921.imp@bsdimp.com> <4AE76611.4030104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4AE76611.4030104@FreeBSD.org>
Alexander Motin <mav@FreeBSD.org> writes:
: M. Warner Losh wrote:
: > In message: <200910261123.n9QBNfJY087028@svn.freebsd.org>
: > Alexander Motin <mav@FreeBSD.org> writes:
: > : Author: mav
: > : Date: Mon Oct 26 11:23:41 2009
: > : New Revision: 198487
: > : URL: http://svn.freebsd.org/changeset/base/198487
: > :
: > : Log:
: > : Round timeout up when converting CAM milliseconds to ATA seconds.
: >
: > This implements ceil(timeout) rather than round(timeout). Is that
: > intended?
:
: Yes. It is better to turn 400ms to 1s rather then 0. Usually timeouts
: aren't so short to make it important, but I have seen such case once, so
: it is possible to predict another.
OK. I was curious because the commit message was ambiguous and could
be taken to mean two different things. If that's the real intent,
then the code does that and I'm happy.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091027.154213.1640491474.imp>