Date: Tue, 27 Apr 1999 15:20:31 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha cons.c mem.c promcons.c sys_machdep.c src/sys/alpha/tlsb zs_tlsb.c src/sys/dev/ata atapi-cd.c src/sys/dev/en midway.c src/sys/dev/syscons syscons.c src/sys/dev/vinum vinum.c src/sys/dev/vn vn.c src/sys/gnu/ext2fs ... Message-ID: <19637.925219231@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 27 Apr 1999 22:39:33 %2B1000." <199904271239.WAA23086@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199904271239.WAA23086@godzilla.zeta.org.au>, Bruce Evans writes:
>> Suser() simplification:
>
>I thought we decided that this was too painful.
I've grown thicker skin :-)
It was actually not that bad after all, and we will have more
and worse changes between 3.X and 4.0 than this.
I have just cleaned up the immediately obvious bogons, and there
are 30 calls to suser_xxx() left now, most of which seem correct
to me (filesystems mostly).
The next step will probably not happen until I commit the jail
code, then I will change suser_xxx() to:
suser_xxx(struct proc *, struct ucred *, int flags)
and work something like:
if (!cred && !proc)
panic("THINK!");
if (!cred)
cred = proc->p_ucred
...
The flags will be used to determined if jailed roots are OK.
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
FreeBSD -- It will take a long time before progress goes too far!
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19637.925219231>