Date: Tue, 15 Mar 2005 20:58:15 +0100 From: Jose M Rodriguez <josemi@freebsd.jazztel.es> To: freebsd-current@freebsd.org Cc: Jose M Rodriguez <josemi@freebsd.jazztel.es> Subject: Re: rcNG changes/aditions Message-ID: <200503152058.16299.freebsd@redesjm.local> In-Reply-To: <20050315062548.GA42826@gothmog.gr> References: <200503142306.54642.freebsd@redesjm.local> <20050315062548.GA42826@gothmog.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
El Martes, 15 de Marzo de 2005 07:25, Giorgos Keramidas escribió:
> On 2005-03-14 23:06, Jose M Rodriguez <josemi@freebsd.jazztel.es>
wrote:
> > update to PR conf/75137 (sound modules): I rework this adding
> > support for preloaded modules to /etc/rc.subr
> >
> > +#
> > # run_rc_command argument
>
> [...]
>
> > + # try to load ${name}_modules
> > + #
> > + eval "_modules=\$${name}_modules"
> > + if [ -n "${_modules}" ]; then
> > + debug "run_rc_command: kldload ${_modules}."
> > + eval "preload_modules ${_modules}"
> > + _return=$?
> > + [ $_return -ne 0 ] && [ -z "$rc_force" ] &&
> > + return 1
> > + fi
>
> What happens if some of the modules are already loaded and rc_force
> is not set? It looks like this may cause run_rc_command() to fail,
> even though the modules are loaded and a subsequent run of the rc
> command would succeed if attempted.
>
preload_modules test if the module is loaded before trying to load. It
only load what is not loaded before. I'm not sure if the logic is 100%
safe, but I tested this case.
> - Giorgos
>
--
josemi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503152058.16299.freebsd>