Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Apr 2017 21:58:30 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Rick Macklem <rmacklem@uoguelph.ca>
Cc:        Bruce Evans <brde@optusnet.com.au>, Rick Macklem <rmacklem@freebsd.org>,  "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r317240 - head/sys/fs/nfs
Message-ID:  <20170421215452.R2416@besplex.bde.org>
In-Reply-To: <YTXPR01MB01896B8154F83A3CFFA31FB9DD1A0@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM>
References:  <201704210150.v3L1ofgl014509@repo.freebsd.org>, <20170421141623.A1141@besplex.bde.org> <YTXPR01MB01896B8154F83A3CFFA31FB9DD1A0@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Apr 2017, Rick Macklem wrote:

> Yes, I agree that hardcoded values are bad.
> Thanks for pointing out the constants in sys/conf.h, I can use those instead.
> sys/conf.h does not have an entry for "nogroup", which is what has been used
> by nfsuserd since it was written.
>
> Is adding an entry to sys/conf.h for GID_NOGROUP ok to do?

It is currently mostly for device configuration, but the user/group defines
in it are already misplaced (for convenience) so a couple more wouldn't hurt.

> rick
> ps: I hope you don't mind the top post...

I prefer not.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170421215452.R2416>