Date: Tue, 21 Apr 2009 12:02:59 -0700 From: Nate Lawson <nate@root.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: sclark46@earthlink.net, freebsd-acpi@freebsd.org, Ian Smith <smithi@nimnet.asn.au> Subject: Re: 6.x acpi powerbutton Message-ID: <49EE1863.1000306@root.org> In-Reply-To: <49EDFAED.4030606@icyb.net.ua> References: <49DE1F8B.2080400@earthlink.net> <49DE2E6D.5050001@icyb.net.ua> <49DE596E.2050406@earthlink.net> <49DEFF53.1040306@icyb.net.ua> <49DF7A1C.90009@root.org> <20090418043432.O34434@sola.nimnet.asn.au> <49E8D824.1000001@root.org> <20090417200726.GG3014@deviant.kiev.zoral.com.ua> <49E8E6E3.40304@root.org> <49EDFAED.4030606@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Andriy Gapon wrote:
> on 17/04/2009 23:30 Nate Lawson said the following:
>> Sure. Perhaps Andriy will pick up this task after reworking the suspend
>> path code for S5? It seems related.
>
> Oh I think that this would be a much easier and independent task.
> Right now I have the following in my local tree, but I think that it might be
> better to limit the message to S5 state only, so that people with laptops do not
> complain about extra spam.
>
> diff --git a/sys/dev/acpica/acpi.c b/sys/dev/acpica/acpi.c
> index 8a592d2..f3e0c1f 100644
> --- a/sys/dev/acpica/acpi.c
> +++ b/sys/dev/acpica/acpi.c
> @@ -2169,6 +2169,8 @@ acpi_ReqSleepState(struct acpi_softc *sc, int state)
> if (state < ACPI_STATE_S1 || state > ACPI_STATE_S5)
> return (EINVAL);
>
> + printf("acpi: request to enter S%d sleep state\n", state);
> +
> /* S5 (soft-off) should be entered directly with no waiting. */
> if (state == ACPI_STATE_S5) {
> if (ACPI_SUCCESS(acpi_EnterSleepState(sc, state)))
>
I don't think that's what they're asking for. The normal shutdown
process creates log entries, even if destined for poweroff. For example,
shutdown -p will log before powering off. acpi_ReqSleepState() can come
through /dev/apm, sysctl, etc. as well as the power button handler.
They are interested in the initiator of the event, the button itself. So
you'd be adding a printf to the power button handler, "power button
pressed". Then the normal shutdown messages would be logged but they
would know the reason. Remember that with sysctl, you can configure
different events to button mappings. So the power button could be used
to initiate a suspend, for example.
--
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49EE1863.1000306>