Date: Sun, 24 Nov 2002 17:12:13 -0800 From: Terry Lambert <tlambert2@mindspring.com> To: Giorgos Keramidas <keramida@ceid.upatras.gr> Cc: freebsd-chat@FreeBSD.ORG Subject: Re: Style(9) question Message-ID: <3DE178ED.6883CEC2@mindspring.com> References: <20021122193040.GA23078@dogma.freebsd-uk.eu.org> <20021122214405.GA11011@HAL9000.homeunix.com> <8gof8g83w4.f8g@localhost.localdomain> <20021124090603.GA3172@HAL9000.homeunix.com> <20021124100846.GC51850@raggedclown.net> <20021124162717.GA576@gothmog.gr> <3DE1739B.5AD2AEA7@mindspring.com> <20021125010242.GE15728@gothmog.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
Giorgos Keramidas wrote: > On 2002-11-24 16:49, Terry Lambert <tlambert2@mindspring.com> wrote: > > Giorgos Keramidas wrote: > > > On 2002-11-24 11:08, Cliff Sarginson <cls@raggedclown.net> wrote: > > > > Can someone tell me if working code has ever been rejected from FreeBSD > > > > sources because it grossly violated the style guidelines ? > > > > > > Not really "rejected", but if you troll the PR database for a while, > > > you will notice followups to the spirit of ``This looks fine, but it > > > doesn't fit the style of the affected sources. Can you please fix > > > this, and post the new patch in a followup?'' > > > > How about just committing the fix, and filing a "style PR" against > > the working code, instead of having style(9) compliant broken code? > > That makes the PR databas grow linearly in relation to the number of > submitted PRs that have ``style issues''. Actually, it only grows relative to the number of people for whom style(9) is their sacred cow. 8-). Most people care about the code working, more than about how pretty it is. > I am more in favor of fixing any style issues, then commiting the > fix, and closing the PR with a notice to the spirit of "I have > changed the diff a bitt, because of `foo', and have committed it > in revision x.y.z of `bar'." This is good too. It puts the style(9) compliance onus onto people who care. > This way both the submitter and people who read the bug report in the > future, can quickly spot the commit and see what was done differently. > Why it was done differently, is what should be noted when the PR closes. Yes. The issue, though, was rejection of bug fixes on the basis of style(9). The heart of the issue is which of the two things is more important: compliance with style(9), or the fixing of bugs. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3DE178ED.6883CEC2>