Date: Sat, 11 Mar 2017 19:00:19 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: "Rodney W. Grimes" <rgrimes@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315091 - head/share/termcap Message-ID: <58F3A212-D538-4D21-A2ED-29DB934CA040@gmail.com> In-Reply-To: <201703120037.v2C0bjdq045397@repo.freebsd.org> References: <201703120037.v2C0bjdq045397@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 11, 2017, at 16:37, Rodney W. Grimes <rgrimes@FreeBSD.org> wrote: > > Author: rgrimes > Date: Sun Mar 12 00:37:45 2017 > New Revision: 315091 > URL: https://svnweb.freebsd.org/changeset/base/315091 > > Log: > Revert r314833 until the problem with INSTALL_RSYMLINKS can be found > as it appears to break arm release builds. > > PR: 217705 > Reported by: cyclaero@gmail.com > Approved by: grehan (mentor) implict as reverting > > Modified: > head/share/termcap/Makefile > > Modified: head/share/termcap/Makefile > ============================================================================== > --- head/share/termcap/Makefile Sat Mar 11 22:34:02 2017 (r315090) > +++ head/share/termcap/Makefile Sun Mar 12 00:37:45 2017 (r315091) > @@ -24,6 +24,6 @@ termcap.db: termcap > cap_mkdb ${CAP_MKDB_ENDIAN} -f ${.TARGET:R} ${.ALLSRC} > > etc-termcap: > - ${INSTALL_RSYMLINK} ${BINDIR}/misc/termcap ${DESTDIR}/etc/termcap > + ${INSTALL_SYMLINK} ${BINDIR}/misc/termcap ${DESTDIR}/etc/termcap Rod, You needed to add ${DESTDIR} to both the source and the destination target, as I’ve said more than once in other reviews/emails. This is how install -l rs determines the relative path from the source to the destination — otherwise you’re creating a relative path from ${BINDIR}/misc -> ${DESTDIR}/etc . Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYxLnEAAoJEPWDqSZpMIYVz+UP/38Oss3qGtfvWojwKljM+0fi K7onKbR+XjQ8qS1cVSFctOaX2OcJPLxKlxJ3tyb+mHxu+EvJrpPxIBRQ8KKBu0P1 p1k0WPGUBvAG4mlP6dt2uY51YzuMkVWPQlU2PtweMvPqb/2g36l6S3+bQs+57y8p R48dMXx0I8Z9sJl8AQktGQuJ6bq4w75Jn2VIpUUDvPJ/Jfp7fehX+mL3b8IT85lF BtrgXAIo5rs+rOd1K/WNyOyKnWi7pnWfIZuzWxEFdz/ZmmoFqO4YUwYy4EUwKylh ZixgounCMCAfUHgP8knLVDW2Qx8eGQIV3XazwWaa27f9Mlgdj7b2yMreNimgrZwC KJ8lDPUS/JcrQ9R9ybJcywK9tGwArOvoMYMPP0H/UKNQQA3w08JBju65Ti4o/Yxa rb+7Q65eom4sd1ZI6zFlYmBpUFc3akOBzkLIuBuy7QTZlonuwT8VN1MRxv0530E5 FOaGOsJe8dVDepqMjWzqgAcvIxfuv4UY189fFpZx/Gn8YBXayoptaTdbWq07PzNz Zl82DIcHsG1FNNuig4QnVfoWQoyuF1HXxJlcWYKOpw8OTNL0SFL8w6fcc+xlMySZ Hk1Ljrqdy6kvZS8W3Zb8jMpV77NJNJwF7+iVck0T1nNGPCiHN+5zwvZwQc8tHj+v Rerl3USh+qmyr0GG86bq =9jyF -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?58F3A212-D538-4D21-A2ED-29DB934CA040>