Date: Mon, 26 Dec 2022 23:22:49 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: Nuno Teixeira <eduardo@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> In-Reply-To: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 26 Dec 2022, Nuno Teixeira wrote: > .if !exists(/usr/include/omp.h) > -USES+= compiler:gcc-c++11-lib > +USES+= compiler:c++14-lang > +USE_GCC= yes > .else > -USES+= compiler:c++11-lang > +USES+= compiler:c++14-lang > .endif This sets USES+= compiler:c++14-lang in both the if-arm and the else-arm. Why not set this unconditionally then? And combining compiler:c++14-lang and USE_GCC=yes is odd; I don't think that really works. Are you sure this entire block is still necessary at all? Where would it make a difference? Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8082ef57-e8b6-adc0-5587-a580ce8dbb98>