Date: Tue, 22 May 2007 11:55:26 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: cvs-src@FreeBSD.org, Alfred Perlstein <alfred@freebsd.org>, Andre Oppermann <andre@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c Message-ID: <20070522115320.C50138@fledge.watson.org> In-Reply-To: <863b1pyw6e.fsf@dwp.des.no> References: <200705192051.l4JKp0rF074703@repoman.freebsd.org> <20070522003856.GX21795@elvis.mu.org> <20070522112825.U50138@fledge.watson.org> <863b1pyw6e.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-73080879-1179831326=:50138 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Tue, 22 May 2007, Dag-Erling Sm=F8rgrav wrote: > Robert Watson <rwatson@FreeBSD.org> writes: >> Alfred Perlstein <alfred@freebsd.org> writes: >>> Is this the same bug that used to be in sendfile but got corrected some= =20 >>> years back? >> Dunno, but it sounds like we really need a comprehensive set of edge-cas= e=20 >> tests for sendfile. > > This was not an edge case. The edge case (no offset, no length, no heade= r)=20 > was the one that worked; it was the non-trivial case (non-zero offset,=20 > explicit length, non-empty header) that was broken. Nobody noticed becau= se=20 > existing code (Apache, ftpd) only exercises the edge case. I stand corrected. :-) Robert N M Watson Computer Laboratory University of Cambridge --0-73080879-1179831326=:50138--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070522115320.C50138>