Date: Sat, 21 Sep 2002 23:56:58 -0500 (CDT) From: Mike Silbersack <silby@silby.com> To: Mike Silbersack <silby@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20020921235350.Q603-100000@patrocles.silby.com> In-Reply-To: <200209220448.g8M4mUJZ002542@freefall.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Unfortunately, this amount of time still trips PHK's timeout check under DIAGNOSTIC. With the other changes Harti has proposed, we may be able to get it down further. However, he's currently on vacation, so that'll have to wait a few weeks. OTOH, at least this ensure that scheduling works normally on systems with HZ=100. I'm rather curious how badly ~10ms timeouts affected general operation if you had multiple xl nics in a box. Mike "Silby" Silbersack On Sat, 21 Sep 2002, Mike Silbersack wrote: > silby 2002/09/21 21:48:30 PDT > > Modified files: > sys/pci if_xl.c > Log: > Remove all DELAY(1) calls around MII operations in the XL driver. > According to the MII specification, the delay produced by our > reads alone are sufficient for correct operation. > > This reduces the time mii_tick takes from 10ms to ~1ms here. That's > still a lot, but much better than before. > > Submitted by: Harti Brandt <brandt@fokus.gmd.de> > MFC after: 3 weeks > > Revision Changes Path > 1.107 +0 -17 src/sys/pci/if_xl.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the messagehelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020921235350.Q603-100000>