Date: Wed, 2 Dec 2009 15:29:04 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Dima Panov <fluffy@fluffy.khv.ru> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: svn commit: r199827 - in head: include lib/libc/compat-43 sys/sys Message-ID: <20091202132904.GH2368@deviant.kiev.zoral.com.ua> In-Reply-To: <200912021926.02346.fluffy@fluffy.khv.ru> References: <200911261349.nAQDnco2083469@svn.freebsd.org> <200912021926.02346.fluffy@fluffy.khv.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--h2J70RNbM0WNXG3M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 02, 2009 at 07:25:56PM +1000, Dima Panov wrote: > On Thursday 26 November 2009 23:49:38 Konstantin Belousov wrote: > > Author: kib > > Date: Thu Nov 26 13:49:37 2009 > > New Revision: 199827 > > URL: http://svn.freebsd.org/changeset/base/199827 > >=20 > > Log: > > Implement sighold, sigignore, sigpause, sigrelse, sigset functions > > from SUSv4 XSI. Note that the functions are obsoleted, and only > > provided to ease porting from System V-like systems. Since sigpause > > already exists in compat with different interface, XSI sigpause is > > named xsi_sigpause. > >=20 > > Reviewed by: davidxu > > MFC after: 3 weeks > >=20 > > Modified: > > head/include/signal.h > > head/lib/libc/compat-43/Makefile.inc > > head/lib/libc/compat-43/Symbol.map > > head/lib/libc/compat-43/sigcompat.c > > head/lib/libc/compat-43/sigpause.2 > > head/sys/sys/signal.h > > head/sys/sys/signalvar.h >=20 > kib, you forgot about osversion bump, it is strongly needed. No. My interpretation of __FreeBSD_version is that the bump indicates incompatible change in the interfaces. Sometime it is used to mark the point where big changes hit the tree, possibly not related to interface change. Also, __FreeBSD_version denotes the kernel "version". We do support running earlier usermode on the later kernels. Think about kernel-only upgrades, compatXx libs and jails which can run arbitrary earlier usermode. (The change in question is purely libc). Said this, I think it is actually harmful practice to bump __FreeBSD_version after API additions or feature implementation. I can bump version for this case, but due to the above reason, it would not make much sense. >=20 > This changeset caused jdk (may be not only jdk) breakage, as jdk-bsd-patc= hes > always provide own implementations of sigingnore() for FreeBSD. >=20 > Patch for jdk16 port will be ready soon. Ok, thanks for working on this. --h2J70RNbM0WNXG3M Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAksWa58ACgkQC3+MBN1Mb4hLuACg7g8APMvdYvJweHwy6Zyfn7Wl +b8Anj9tGX1ZpyLFas+xlIFJAy+YeAJQ =jyC5 -----END PGP SIGNATURE----- --h2J70RNbM0WNXG3M--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091202132904.GH2368>