Date: Mon, 13 Jan 2020 20:43:49 +0200 From: Toomas Soome <tsoome@me.com> To: Ian Lepore <ian@freebsd.org> Cc: Toomas Soome <tsoome@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib Message-ID: <4437F251-43CC-4DED-B449-00A9516C75E2@me.com> In-Reply-To: <5a3e388ed5c91a6d1f88ecc91c08dc103d0369d1.camel@freebsd.org> References: <202001131822.00DIMtrW016338@repo.freebsd.org> <5a3e388ed5c91a6d1f88ecc91c08dc103d0369d1.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 13. Jan 2020, at 20:31, Ian Lepore <ian@freebsd.org> wrote: >=20 > On Mon, 2020-01-13 at 18:22 +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Mon Jan 13 18:22:54 2020 >> New Revision: 356693 >> URL: https://svnweb.freebsd.org/changeset/base/356693 >>=20 >> Log: >> loader: allocate properly aligned buffer for network packet >>=20 >> Use memalign(4, size) to ensure we have properly aligned buffer. >>=20 >> MFC after: 2 weeks >>=20 >> Modified: >> head/stand/efi/libefi/efinet.c >> head/stand/i386/libi386/pxe.c >> head/stand/libofw/ofw_net.c >> head/stand/uboot/lib/net.c >>=20 >=20 > The malloc implementation in libstand already g'tees minimum alignment > of 16 bytes on most arches, 64 bytes on arches that use u-boot (see > libsa/zalloc_defs.h). So how does this change anything? >=20 Hi! Well, given the amount of knobs etc, it does not hurt to be explicit, = does it? rgds, toomas=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4437F251-43CC-4DED-B449-00A9516C75E2>