Date: Fri, 22 Jan 1999 03:54:56 +0100 (CET) From: dan@obluda.cz To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: bin/9613: [PATCH] IPFW command-line parsing error Message-ID: <199901220254.DAA02648@fio.cz>
next in thread | raw e-mail | index | archive | help
>Number: 9613
>Category: bin
>Synopsis: [PATCH] IPFW command-line parsing error
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 21 21:40:01 PST 1999
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 2.2.8-RELEASE i386
>Organization:
Obludarium
>Environment:
no special environment settings, standard instalation
$Id: ipfw.c,v 1.34.2.20 1998/10/12 17:29:15 luigi Exp $
>Description:
/sbin/ipfw/ipfw.c:
when
ipfw [-aftN] list [number ...]
is called, but 'number' parameter is not number, the ipfw wrote bad
error message and (sometime) ABEND.
It is caused by missing dereference of printed parameter.
The warn routine should be replaced by warnx, because the value of
errno is set to nothing relevant in this context.
>How-To-Repeat:
ipfw l -a (for example)
>Fix:
--- ipfw.c.ORIG Mon Oct 12 19:29:15 1998
+++ ipfw.c Thu Jan 21 21:09:03 1999
@@ -493,7 +493,7 @@
rulenum = strtoul(*av++, &endptr, 10);
if (*endptr) {
exitval = 1;
- warn("invalid rule number: %s", av - 1);
+ warnx("invalid rule number: %s", *(av - 1));
continue;
}
seen = 0;
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901220254.DAA02648>