Date: Mon, 11 Nov 1996 15:31:13 -0500 (EST) From: John Dyson <dyson@dyson.iquest.net> To: ache@nagual.ru (=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=) Cc: dyson@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/as/opcode i386.h Message-ID: <199611112031.PAA03109@dyson.iquest.net> In-Reply-To: <199611111943.WAA00385@nagual.ru> from "=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=" at Nov 11, 96 10:43:31 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > dyson 96/11/11 11:03:53 > > > > Modified: gnu/usr.bin/as/opcode i386.h > > Log: > > Add the PPro %cr4 register to the supported registers in the > > assembler. > > > > Revision Changes Path > > 1.5 +2 -1 src/gnu/usr.bin/as/opcode/i386.h > > > > Maybe locore.s code need to be #ifdefed for CPUs >= PPro? > I guess it would be minimally useful -- the system will not attempt to execute the instructions if not PPro though. (We are only talking several longwords of overhead, executed only once.) The pmap code is probably a better candidate, because the code is executed many times. I generally find #ifdef pollution to obscure code. But if it seems that we are worried about the few bytes, then I guess I wouldn't be that opposed to the #ifdefs. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611112031.PAA03109>