Date: Mon, 21 May 2007 15:35:47 +0100 From: Florent Thoumie <flz@FreeBSD.org> To: =?ISO-8859-15?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <4651AE43.9030300@FreeBSD.org> In-Reply-To: <86r6pas14i.fsf@dwp.des.no> References: <200705211021.l4LALdGa025468@repoman.freebsd.org> <86k5v2tnhv.fsf@dwp.des.no> <4651884F.3080207@FreeBSD.org> <867ir2tibr.fsf@dwp.des.no> <4651A262.2070905@FreeBSD.org> <86r6pas14i.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Dag-Erling Smørgrav wrote:
> Florent Thoumie <flz@FreeBSD.org> writes:
>> Let's just set USE_XLIB=yes if X_WINDOW_SYSTEM == xfree86-4 and USE_XORG
>> is defined.
>
> Yes, that would be the easiest solution.
>
> What about USE_X_PREFIX, BTW? I assume that X.org-aware ports are not
> supposed to define it? Perhaps there should be a check for that,
> issuing a warning (or aborting the build) if both USE_X_PREFIX and
> USE_XORG are set at the same time.
This one should go as well.
>> DES or I could prepare a bpm patch for this if there's an empty slot on
>> pointyhat for a new exp-run.
>
> Something like this?
>
> @@ -1916,9 +1921,13 @@
> ${X11BASE}/lib/X11/fonts/misc/fonts.alias:${X_FONTS_ALIAS_PORT}
> .endif
>
> +.if defined(USE_XPM)
> +USE_XORG+= xpm
> +.endif
> +
> .if ${X_WINDOW_SYSTEM:L} == xfree86-4
>
> -.if defined(USE_XPM)
> +.if defined(USE_XORG)
> USE_XLIB= yes
> .endif
>
> @@ -1927,14 +1936,6 @@
>
> .else
>
> -.if defined(USE_XPM)
> -LIB_DEPENDS+= Xpm.4:${PORTSDIR}/x11/libXpm
> -# XXX - At some point we'll have to fix ports to use USE_XORG to
> -# the right value and remove both USE_XPM and USE_XLIB. Hopefully
> -# XFree86-4 will be gone in the meantime.
> -USE_XLIB= yes
> -.endif
> -
> XAWVER= 8
> PKG_IGNORE_DEPENDS?= 'this_port_does_not_exist'
>
>
> Note that the file numbers won't line up, because I have other patches
> in my bsd.port.mk.
Seems good to me. I could as well start replacing both
(USE_XLIB|USE_X_PREFIX)=yes with USE_XORG=yes. We'll take care of using
finer dependencies later.
Also, USE_IMAKE currently implies USE_XLIB, I'm not sure this is really
needed but I haven't really looked into this yet.
--
Florent Thoumie
flz@FreeBSD.org
FreeBSD Committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGUa5HMxEkbVFH3PQRCgQVAJ43khgGvnFtdoM8Igpt+QHDNBqPGQCeNBvX
SlF2HXBGdBXnypcmFNpRGNs=
=Gfsu
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4651AE43.9030300>