Date: Mon, 20 Mar 2006 10:48:04 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: "Christian S.J. Peron" <csjp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20060320074804.GC1102@FreeBSD.org> In-Reply-To: <200603182327.k2INRMJR030740@repoman.freebsd.org> References: <200603182327.k2INRMJR030740@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 18, 2006 at 11:27:22PM +0000, Christian S.J. Peron wrote: C> csjp 2006-03-18 23:27:22 UTC C> C> FreeBSD src repository C> C> Modified files: C> sys/kern kern_descrip.c C> Log: C> Back out fd optimization introduced in revision 1.280 as it appears to be C> really breaking things. Simple "close(0); dup(fd)" does not return descriptor C> "0" in some cases. Further, this change also breaks some MAC interactions with C> mac_execve_will_transition(). Under certain circumstances, fdcheckstd() can C> be called in execve(2) causing an assertion that checks to make sure that C> stdin, stdout and stderr reside at indexes 0, 1 and 2 in the process fd table C> to fail, resulting in a kernel panic when INVARIANTS is on. C> C> This should also kill the "dup(2) regression on 6.x" show stopper item on the C> 6.1-RELEASE TODO list. C> C> This is a RELENG_6 candidate. C> C> PR: kern/87208 C> Silence from: des C> MFC after: 1 week Thanks, Christian! -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060320074804.GC1102>