Date: Mon, 16 Oct 2006 09:21:31 +0800 From: Cheng-Lung Sung <clsung@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: freebsd-current@FreeBSD.org, freebsd-bugs@FreeBSD.org, Cheng-Lung Sung <clsung@FreeBSD.org>, FreeBSD-gnats-submit@FreeBSD.org, freebsd-hackers@FreeBSD.org Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h Message-ID: <20061016012131.GA22894@FreeBSD.csie.nctu.edu.tw> In-Reply-To: <20061016011559.W61639@delplex.bde.org> References: <20061015135710.A28897E98D@FreeBSD.csie.nctu.edu.tw> <20061016011559.W61639@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Oct 16, 2006 at 01:21:59AM +1000, Bruce Evans wrote:
> On Sun, 15 Oct 2006, Cheng-Lung Sung wrote:
>
> >System: FreeBSD.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Thu May
> >11 14:31:45 CST 2006
> >root@FreeBSD.csie.nctu.edu.tw:/home/usr.obj/usr/src/sys/FREEBSD i386
> >
> >>Description:
> >- sys/sem.h has included sys/ipc.h, which includes sys/_types.h
> > but it (and its including files) does not include sys/types.h
> >- therefore, in sys/sem.h struct semid_ds declares "time_t sem_otime;"
> >...etc
> >- if we only compile a program which do not include sys/types.h, it will
> >fail.
>
> Including sys/types.h would add lots of namespace pollution which
> sys/ipc.h and sys/sem.h are trying hard to avoid. sem.h is trying too
> hard -- POSIX requires it to declare time_t (and pid_t, key_t and size_t,
> which it already declares).
>
> Bruce
You're right, I should try to pass COMMON_HEADERS to ruby-sysipc
instead of polluting namespace.
Thanks,
--
Cheng-Lung Sung - clsung@
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQFFMt6a+AeJ85Vui8ERAkpiAKCT0qnMLSJa1lUsjqBA7XOpvkKeQgCfc0sn
r/6xcrfx71DYTCstiZC8GPA=
=P6zp
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061016012131.GA22894>