Date: Mon, 18 Nov 2013 14:55:06 -0500 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r258310 - head/release Message-ID: <20131118195506.GT1643@glenbarber.us> In-Reply-To: <20131119.034852.1148136397426813684.hrs@allbsd.org> References: <201311181625.rAIGPuRG078815@svn.freebsd.org> <20131119.034852.1148136397426813684.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Tue, Nov 19, 2013 at 03:48:52AM +0900, Hiroki Sato wrote:
> gj> +dvd:
> gj> +# Install system
> gj> + mkdir -p ${.TARGET}
> gj> + cd ${WORLDDIR} && ${IMAKE} installkernel installworld distribution \
> gj> + DESTDIR=${.OBJDIR}/${.TARGET} WITHOUT_RESCUE=1 WITHOUT_KERNEL_SYMBOLS=1 \
> gj> + WITHOUT_PROFILE=1
>
> Please remove WITHOUT_PROFILE=1 here.
>
Ok.
> gj> -export PKG_ABI="freebsd:$(echo ${REVISION} | tr -d '.0'):x86:64"
> gj> +export PKG_ABI="freebsd:$(echo ${REVISION} | sed -e 's/\.[0-9]//'):x86:64"
>
> PKG_ABI=freebsd:${REVISION%.[0-9]*}:x86:64 is simpler than invoking
> tr or sed. However, pkg-stage.sh should have a mapping rule from
> TARGET and TARGET_ARCH, not in arch specific config files, I think.
> Other than the package list, variables are not arch-specific.
>
The pkg(8) ABI does not map directly to anything we use ('amd64' or
'i386') unfortunately.
> Does this guarantee that the packages downloaded by pkg(8) are for a
> specific release? And I think fetching packages can be done just
> after svn co stage in release.sh. Collecting up necessity of network
> access (including fetching distfiles for docproj) before entering the
> chroot environment makes redoing the release build easier.
>
I don't think it has been discussed yet where packages built for
a specific release will exist. Anyway, I would like to avoid directory
hierarchy pollution outside of the dvd/ directory, this is why I use it
for PKG_CACHEDIR directly.
Glen
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iQIcBAEBCAAGBQJSinCaAAoJELls3eqvi17QS/sP/R4uw45LEMK+6S7oCtfTFMNY
kO0P4Ta8J2RUOEGnXuGC2ELyaqWKVC3zNJwqOJQGXIQFwGQ4nHkLU2CXeyOPE6C2
FT2R/H8ciXIB4WB1Lz7oHeTKNt19AafYDR/Iw7AzwJTbgrCoiwAkVSXB4E5XtB6Z
SXWiv11euIwQhP0ZiUTbrRlm9bIezIZvBJkZIWt2fM2joMeGWCyUFO5fWSIQF8UM
t9ruUDdreXVj1PVyZGIZAGFIEOF4e1Yddqu7owysiyNDW2gU7skTLqWj+h+6V4dy
Nl/V3vNF9EgIc6CDZccKfqkEGGN9DHAt40ANfN2qAE+5SPRfXs+CGjHxz06o0pnM
xzRMYzgQKKmnoGKZG0HpCEVNCmBqgqZ3m6C/690chnqn1N086i2bmnexsYps+aAA
xNZrqwscb8c+54TQWD7AyK08b103o9y817ZqCAk7OnxbB30IOFCBII8qAc6iDlUO
DAPosvwdzTEol2LPhPMqNxias+PUSSco9luWAa0INxhytf4CmMRjLMk6uUF+BBd1
9EJl1oTEfmYeowHkAGH9Irq3wM+iQccFSrHUB222NOrUwBRZc7O7mCvuBSIdhIWo
upvw3v9z3M0pQbJPuOpb/VaOZz+gNlh8zExX0rMIoin6yMnQWtOXGqxa/sVh/2bF
tUO6tqdgFmogrYboJQ9d
=YIHL
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131118195506.GT1643>