Date: Tue, 3 May 2022 16:07:40 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1f7746d81f53 - main - bsdinstall: stop messing with file descriptors Message-ID: <20220503160740.3cae79b06ee16317a4368500@bidouilliste.com> In-Reply-To: <202205031406.243E6WIb078279@gitrepo.freebsd.org> References: <202205031406.243E6WIb078279@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 3 May 2022 14:06:32 GMT Emmanuel Vadot <manu@FreeBSD.org> wrote: > The branch main has been updated by manu: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1f7746d81f53447ac15cc99395bb714d4dd0a4da > > commit 1f7746d81f53447ac15cc99395bb714d4dd0a4da > Author: Corvin Köhne <CorvinK@beckhoff.com> > AuthorDate: 2022-05-03 14:00:09 +0000 > Commit: Emmanuel Vadot <manu@FreeBSD.org> > CommitDate: 2022-05-03 14:02:27 +0000 > > bsdinstall: stop messing with file descriptors > > Throughout the bsdinstall script fd 3 is used by f_dprintf (set through > $TERMINAL_STDOUT_PASSTHRU). By closing file descriptor 3 here, the > final f_dprintf "Installation Completed ... does not work anymore. > > By putting the code into a subshell, file descriptors can be edited > without interference with the calling script. > > Reviewed by: emaste > Differential Revision: https://reviews.freebsd.org/D35113 > Sponsored by: Beckhoff Automation GmbH & Co. KG > MFC after: 3 days Fixes 40923b0c81 "Fix scripted installation from media without local distfiles." -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220503160740.3cae79b06ee16317a4368500>