Date: Sat, 13 Jan 2001 11:44:15 -0500 From: Chris Faulhaber <jedgar@fxp.org> To: Mark Murray <mark@grondar.za> Cc: Kris Kennaway <kris@FreeBSD.ORG>, freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 Message-ID: <20010113114415.A21411@peitho.fxp.org> In-Reply-To: <200101131616.f0DGGoI20517@gratis.grondar.za>; from mark@grondar.za on Sat, Jan 13, 2001 at 06:16:42PM %2B0200 References: <20010113083623.A44479@peitho.fxp.org> <200101131616.f0DGGoI20517@gratis.grondar.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 13, 2001 at 06:16:42PM +0200, Mark Murray wrote: > > On Sat, Jan 13, 2001 at 03:27:27PM +0200, Mark Murray wrote: > > > > > > Looks good to me! > > > > > > > Unfortunately, as Kris pointed out, it creates INSTALLTMP for > > all targets, not just installworld (at least Kris's patch > > removes the unused dir for non-installworld targets). We > > could use the -u option to mktemp(1) and continue to create > > the dir in the installworld: target, though. > > Oops! Right. What does a "make buildworld", "make installworld" say? > I just successfully finished a buildworld/installworld with the following patch. Unfortunately, it does not provide all the safety mktemp(1) would have if the -u options was not used, but is better than $TMPDIR/install.<pid> and works with the current build structure. Alternatively, we could modify the IMAKE invocation in the installworld target and properly use mktemp(1), setting PATH in the target instead of using IMAKEENV. Unfortunately, this would be uglier than just using mktemp -u. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org Index: Makefile.inc1 =================================================================== RCS file: /home/ncvs/src/Makefile.inc1,v retrieving revision 1.180 diff -u -r1.180 Makefile.inc1 --- Makefile.inc1 2000/12/24 14:58:34 1.180 +++ Makefile.inc1 2001/01/13 16:24:16 @@ -130,9 +130,7 @@ STRICTTMPPATH= ${WORLDTMP}/usr/sbin:${WORLDTMP}/usr/bin:${WORLDTMP}/usr/games TMPPATH= ${STRICTTMPPATH}:${PATH} -TMPDIR?= /tmp -TMPPID!= echo $$$$ -INSTALLTMP= ${TMPDIR}/install.${TMPPID} +INSTALLTMP!= /usr/bin/mktemp -d -u -t install # # Building a world goes through the following stages To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010113114415.A21411>