Date: Mon, 27 Jul 2026 17:16:02 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 297094] databases/percona-toolkit: version detection broken for databases/mariadb123-server Message-ID: <bug-297094-7788@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=297094 Bug ID: 297094 Summary: databases/percona-toolkit: version detection broken for databases/mariadb123-server Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: mandrews@bit0.com CC: brnrd@freebsd.org, flo@FreeBSD.org CC: brnrd@freebsd.org, flo@FreeBSD.org Percona Toolkit has trouble determining whether it's running on MySQL or MariaDB. For example in pt-online-schema-change, it's doing a "show variables like 'version%'": version | 12.3.2-MariaDB-log version_comment | FreeBSD Ports version_compile_machine | x86_64 version_compile_os | FreeBSD15.1 version_malloc_library | jemalloc 5.3.0-0-g54eaed1d8b56b1aa528be3bdd1877e59c56fa90c version_source_revision | 9f98f82b14a9b939834281672b6d0cf965db69a3 version_ssl_library | OpenSSL 3.5.6 7 Apr 2026 and then looking at the "version_comment" variable that comes back, around line 2048 in pt-online-schema-change (not necessarily limited to that one specific tool though): $args{flavor} = delete $query->{version_comment} if $query->{version_comment}; Elsewhere in the code, it checks to see if flavor contains "mariadb". But "version_comment" always has "FreeBSD Ports" and not "mariadb", probably because databases/mariadb*-server/Makefile (all versions, not just 12.3.x) has: -DCOMPILATION_COMMENT="FreeBSD Ports" I don't know what else depends on COMPILATION_COMMENT being exactly that. I don't know why Percona Toolkit checks version_comment instead of version. So I don't know which port needs a patch -- either to add MariaDB to COMPILATION_COMMENT or to have Percona check "version" instead of or in addition to "version_comment". -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-297094-7788>