Date: Wed, 15 Nov 1995 10:27:56 +0100 From: Poul-Henning Kamp <phk@critter.tfs.com> To: davidg@Root.COM Cc: Bruce Evans <bde@zeta.org.au>, peter@haywire.dialix.com, freebsd-hackers@freebsd.org Subject: Re: Can't NFS mount with latest -current Message-ID: <2628.816427676@critter.tfs.com> In-Reply-To: Your message of "Wed, 15 Nov 1995 00:15:21 PST." <199511150815.AAA00161@corbin.Root.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
> >>>Anyway, Poul-Henning has created two sysctl types.. one is a > >>>null-terminated "C-style" string, and the other is an "opaque" chunk > >>>of byte counted memory. IMHO, the string version should always return > >>>the correct amount of characters that the string actually uses. If > >>>the whole block is to be returned, that's what the opaque type is for. > > > >> Yes, the "size" argument should be used to limit the copy, not prevent i t > >>from happening. We should be using copyoutstr() for this. > > > >We shouldn't be using copyoutstr() for this. > ... > >copyoutstr() is the most complicated routine in support.s, but is > >currently unused. > > Are you saying that you would like to officially remove support for > copyoutstr() in favor of strlen/copyout? I can agree with that. BTW, we > should remove the #if 0'd crap in cpufunc.h: I'd vote for killing copyoutstr too. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2628.816427676>