Date: Tue, 04 Feb 2014 07:59:06 -0700 From: Ian Lepore <ian@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-10@FreeBSD.org Subject: Re: svn commit: r261455 - in stable/10: lib/libc/sparc64/fpu lib/libc/xdr sys/amd64/pci sys/amd64/vmm/intel sys/arm/arm sys/arm/at91 sys/arm/broadcom/bcm2835 sys/arm/econa sys/arm/freescale/imx sys/arm... Message-ID: <1391525946.13026.106.camel@revolution.hippie.lan> In-Reply-To: <201402040336.s143ah3l039786@svn.freebsd.org> References: <201402040336.s143ah3l039786@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2014-02-04 at 03:36 +0000, Eitan Adler wrote: > Author: eadler > Date: Tue Feb 4 03:36:42 2014 > New Revision: 261455 > URL: http://svnweb.freebsd.org/changeset/base/261455 > > Log: > MFC r258779,r258780,r258787,r258822: > > Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this > shifts into the sign bit. Instead use (1U << 31) which gets the > expected result. > > Similar to the (1 << 31) case it is not defined to do (2 << 30). > > This fix is not ideal as it assumes a 32 bit int, but does fix the issue > for most cases. > > A similar change was made in OpenBSD. > This is causing arm breakage, I think r258787 needs to be mfc'd to fix. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1391525946.13026.106.camel>