Date: Thu, 30 Sep 2021 21:02:51 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 221854] makefs: Reject UFS labels that are too long to fit Message-ID: <bug-221854-227-0TpYhWNfZV@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-221854-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221854 Piotr Pawel Stefaniak <pstef@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pstef@freebsd.org --- Comment #2 from Piotr Pawel Stefaniak <pstef@freebsd.org> --- In 2017, Ed imported option parsing from NetBSD so this patch no longer applies. While I support the improvement, it has the side effect that since all strings are handled like this: case OPT_STRARRAY: strlcpy((void *)options[i].value, val, (size_t) options[i].maximum); break; you can't be selective about which truncation is tolerable and which is not. Ed, maybe we should reject any and all truncation errors in this path? -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221854-227-0TpYhWNfZV>