Date: Thu, 26 Apr 2018 20:36:42 -0600 From: Adam Weinberger <adamw@adamw.org> To: fluffy@FreeBSD.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468319 - in head/mail: opensmtpd opensmtpd-devel opensmtpd-devel/files opensmtpd/files Message-ID: <9D94AB40-9623-45BA-8F5C-95B548DF0D40@adamw.org> In-Reply-To: <2315c626-9bc9-35bd-0f61-3f8e77f54237@FreeBSD.org> References: <201804260053.w3Q0r1ls098687@repo.freebsd.org> <03CA4FC0-D636-4A40-A820-AF746EF35499@adamw.org> <2315c626-9bc9-35bd-0f61-3f8e77f54237@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 26 Apr, 2018, at 20:30, Dima Panov <fuffy@FreeBSD.org> wrote: > > > > Adam Weinberger wrote: >>> On 25 Apr, 2018, at 18:53, Dima Panov <fluffy@FreeBSD.org> wrote: >>> >>> Author: fluffy >>> Date: Thu Apr 26 00:53:01 2018 >>> New Revision: 468319 >>> URL: https://svnweb.freebsd.org/changeset/ports/468319 >>> >>> Log: >>> - Pet MDA part, add brackets around Return-Path as per RFC5322 §3.6.6. >>> >>> Missing brackets lead to a panic when a malformed address line >>> is fed to dovecot-lda >>> >>> Submitted by: gahr >>> Reported by: brnrd via dovecot ML >>> Obtained from: https://github.com/OpenSMTPD/OpenSMTPD/pull/847/commits/725ba4fa2ddf23bbcd1ff9ec92e86bbfaa6825c8 >> Thanks for doing this, Dima. This should probably be merged to >> quarterly, no? > > Only Dovecot23+ affected this "bug" yet, so while 2018Q2 lives without > it, MFH is not critically needed. > But yes, I'm also thinking about MFH, just to be sured in. IIRC rspamd had to work around this behavior a while back. It’s certainly a bug fix, but only dovecot seems to have broken spectacularly here recently. I don’t feel strongly about it one way or the other. I defer to your judgement. # Adam — Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9D94AB40-9623-45BA-8F5C-95B548DF0D40>