Date: Fri, 27 Mar 2015 21:11:05 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org Subject: Re: svn commit: r381968 - head/lang/gcc5 Message-ID: <CAMHz58TX-FVyWuH5pR7Sef=%2BP_8=TjmfSnwObQDZGPcPLzhRug@mail.gmail.com> In-Reply-To: <55106F0E.9090700@FreeBSD.org> References: <201503222311.t2MNBE8d075929@svn.freebsd.org> <CAMHz58SEVfiUsrz0f2dMVsvA-kL4e%2BTF2JcuzYBp7bPPEYsCow@mail.gmail.com> <551061EC.5090702@FreeBSD.org> <alpine.LSU.2.11.1503232038520.15042@tuna.site> <55106F0E.9090700@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 24, 2015 at 3:52 AM, Bryan Drewery <bdrewery@freebsd.org> wrote:
> On 3/23/2015 2:44 PM, Gerald Pfeifer wrote:
> > On Mon, 23 Mar 2015, Bryan Drewery wrote:
> >>> USE_LDCONFIG stores the directory name to
> >>> ${LOCALBASE}/libdata/ldconfig/${UNIQUENAME}.
> >>> Since lang/gcc* now share same PORTNAME (gcc), you need to
> >>> set UNIQUENAME manually.
> >> I just hit this. I've fixed it in r382022.
> >
> > Thanks for fixing this, Bryan, but...
> >
> > ...doesn't this point to a design problem with the infrastructure?
>
> Definitely. I think UNIQUENAME is now really only used for USE_LDCONFIG.
> It may make sense to default it to the values I put into the gcc ports.
>
>
UNIQUENAME is also used by bsd.options.mk for UNIQUENAME_{SET,UNSET}
support and OPTIONSFILE.
I would vote for appending PKGNAMESUFFIX to UNIQUENAME.
Regards,
sunpoet
>
> > Mk/bsd.ports.mk says:
> >
> > # UNIQUENAME - A name for your port that is globally unique. By
> default,
> > # this is set to ${LATEST_LINK} when LATEST_LINK is set,
> > # and to ${PKGNAMEPREFIX}${PORTNAME} otherwise.
> >
> > # PKGNAMESUFFIX - Suffix to specify compilation options or a version
> > # designator (in case there are different versions of
> > # one port as is the case for Tcl).
> >
> > If PKGNAMESUFFIX is used as Mat suggested (to carry a version number),
> > shouldn't it become part of UNIQUENAME? Can this be improved?
> >
> > If not, I guess I should just revert PORTNAME to gcc47, gcc48, and
> > so forth. Using PKGNAMESUFFIX is not providing the expected benefit.
> > And things just are becoming more complex. :-(
> >
> > Gerald
> >
>
>
> --
> Regards,
> Bryan Drewery
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TX-FVyWuH5pR7Sef=%2BP_8=TjmfSnwObQDZGPcPLzhRug>