Date: Sun, 18 Sep 2011 21:44:03 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Juergen Lock <nox@jelal.kn-bremen.de> Cc: Brendan Fabeny <bf1783@gmail.com>, freebsd-multimedia@freebsd.org Subject: Re: Has anyone tested the jack update - am I ok to commit it? Message-ID: <alpine.LNX.2.00.1109182142310.2965@gerinyyl.fvgr> In-Reply-To: <20110918185647.GA28605@triton8.kn-bremen.de> References: <CAGFTUwNMqpOcYLZCzbZ7tj5qqZF6UXm6zv-%2BH3ZxYNa9U9VQCA@mail.gmail.com> <20110918152101.GA88715@triton8.kn-bremen.de> <CAGFTUwObv-92bVdF%2B7YZ7Xdf-gTp-_0N-MOQfq=S_y=40PDApQ@mail.gmail.com> <20110918185647.GA28605@triton8.kn-bremen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, 18 Sep 2011, Juergen Lock wrote: > Hm that never arrived here. :( (Or did you send it to a list only? > Then I missed it.) It was attached to Brandan's previous mail; I'm attaching it here again. > Anyway, you are right, that should be cleaned up. I have now made > a new update including your suggestions and tested it with ardour3 > again: > > http://people.freebsd.org/~nox/tmp/jack-0.121.2.patch I believe this should indeed address a couple of warnings/errors that `portlint -C` issued to diagnose. Gerald [-- Attachment #2 --] Index: Makefile =================================================================== RCS file: /home/pcvs/ports/audio/jack/Makefile,v retrieving revision 1.60 diff -u -r1.60 Makefile --- Makefile 11 Aug 2011 19:19:01 -0000 1.60 +++ Makefile 18 Sep 2011 00:57:10 -0000 @@ -21,9 +21,10 @@ celt0.2:${PORTSDIR}/audio/celt LATEST_LINK= jack -CONFIGURE_ENV= LIBS="${PTHREAD_LIBS}" LDFLAGS="-L${LOCALBASE}/lib" \ - CPPFLAGS="-I${LOCALBASE}/include" \ - CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}" +CFLAGS+= ${PTHREAD_CFLAGS} +CPPFLAGS+= -I${LOCALBASE}/include +LDFLAGS+= -L${LOCALBASE}/lib +CONFIGURE_ENV= LIBS="${PTHREAD_LIBS}" LDFLAGS="${LDFLAGS}" CONFIGURE_ARGS+=--enable-portaudio \ --with-default-tmpdir=/tmp GNU_CONFIGURE= yes @@ -33,14 +34,17 @@ MAN1= jackd.1 jackstart.1 -OPTIONS= ALSA "Build with ALSA compatibility library" off +OPTIONS= ALSA "Build with ALSA compatibility library" off \ + DOCS "Build HTML documents (requires doxygen)" off .include <bsd.port.pre.mk> -.if !defined(NOPORTDOCS) +.if defined(WITH_DOCS) && !defined(NOPORTDOCS) BUILD_DEPENDS+= doxygen:${PORTSDIR}/devel/doxygen +PLIST_SUB+= DOCS="" .else CONFIGURE_ENV+= ac_cv_prog_HAVE_DOXYGEN="false" +PLIST_SUB+= DOCS="@comment " .endif .if exists(${LOCALBASE}/lib/libreadline.so.6) Index: pkg-plist =================================================================== RCS file: /home/pcvs/ports/audio/jack/pkg-plist,v retrieving revision 1.24 diff -u -r1.24 pkg-plist --- pkg-plist 16 Dec 2010 17:34:13 -0000 1.24 +++ pkg-plist 18 Sep 2011 00:58:09 -0000 @@ -53,75 +53,75 @@ lib/libjackserver.so lib/libjackserver.so.0 libdata/pkgconfig/jack.pc -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/annotated.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/classes.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/deprecated.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/doxygen.css -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/doxygen.png -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/files.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/fsm.png -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/functions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/functions_vars.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x65.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x69.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6a.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6d.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6f.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x70.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x73.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x74.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_defs.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_enum.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_eval.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_func.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_type.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_vars.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ClientCallbacks.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ClientFunctions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ClientThreads.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ErrorOutput.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__MIDIAPI.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__NonCallbackAPI.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__PortFunctions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__PortSearching.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ServerControl.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__TimeFunctions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__TransportControl.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/index.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/inprocess_8c.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/jack_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/jack_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/mainpage_8dox.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/modules.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/pages.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/porting-guide.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/porting_8dox.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/simple__client_8c.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/struct__jack__midi__event.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__position__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__data__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__transport__info__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structport__pair__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/thread_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/thread_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport-design.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport_8dox.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/types_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/types_8h_source.html -%%PORTDOCS%%@dirrm share/jack-audio-connection-kit/reference/html -%%PORTDOCS%%@dirrm share/jack-audio-connection-kit/reference -%%PORTDOCS%%@dirrm share/jack-audio-connection-kit +%%DOCS%%share/jack-audio-connection-kit/reference/html/annotated.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/classes.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/deprecated.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/doxygen.css +%%DOCS%%share/jack-audio-connection-kit/reference/html/doxygen.png +%%DOCS%%share/jack-audio-connection-kit/reference/html/files.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/fsm.png +%%DOCS%%share/jack-audio-connection-kit/reference/html/functions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/functions_vars.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x65.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x69.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6a.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6d.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6f.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x70.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x73.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x74.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_defs.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_enum.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_eval.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_func.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_type.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_vars.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ClientCallbacks.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ClientFunctions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ClientThreads.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ErrorOutput.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__MIDIAPI.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__NonCallbackAPI.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__PortFunctions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__PortSearching.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ServerControl.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__TimeFunctions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__TransportControl.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/index.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/inprocess_8c.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/jack_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/jack_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/mainpage_8dox.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/modules.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/pages.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/porting-guide.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/porting_8dox.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/simple__client_8c.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/struct__jack__midi__event.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__position__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__data__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__transport__info__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structport__pair__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/thread_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/thread_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport-design.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport_8dox.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/types_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/types_8h_source.html +%%DOCS%%@dirrm share/jack-audio-connection-kit/reference/html +%%DOCS%%@dirrm share/jack-audio-connection-kit/reference +%%DOCS%%@dirrm share/jack-audio-connection-kit @dirrm lib/jack @dirrm include/jack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1109182142310.2965>