Date: Thu, 7 Mar 2024 12:22:09 +0100 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN Message-ID: <CAGwOe2adJ-rES4gpgj-4s8dmHEmrtzRZp%2B%2BmJPYs-LueR3piJQ@mail.gmail.com> In-Reply-To: <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <CAGwOe2ZE6huqiTAV6zUpJqG6NxmkE2ado2M3oskp972pvBa8DA@mail.gmail.com> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Mar 6, 2024 at 10:34 PM Daniel Engberg < daniel.engberg.lists@pyret.net> wrote: > On 2024-03-04T18:34:16.000+01:00, Fernando Apesteguía < > fernando.apesteguia@gmail.com> wrote: > > On Sun, Mar 3, 2024 at 8:36 PM Daniel Engberg <diizzy@freebsd.org> > wrote: > > > > > > > The branch main has been updated by diizzy: > > > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=ea45a9a534994a1bf97a162168902cebbca1f4c1 > > > > > > commit ea45a9a534994a1bf97a162168902cebbca1f4c1 > > > Author: Daniel Engberg <diizzy@FreeBSD.org> > > > AuthorDate: 2024-03-03 08:29:04 +0000 > > > Commit: Daniel Engberg <diizzy@FreeBSD.org> > > > CommitDate: 2024-03-03 19:26:10 +0000 > > > > > > cad/PrusaSlicer: Mark BROKEN > > > > > > Fails to build, error: no member named 'prior' in namespace > 'boost' > > > > > > Reported by: pkg-fallout > > > --- > > > cad/PrusaSlicer/Makefile | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile > > > index dc125244df20..936e76216daf 100644 > > > --- a/cad/PrusaSlicer/Makefile > > > +++ b/cad/PrusaSlicer/Makefile > > > @@ -12,6 +12,8 @@ WWW= https://www.prusa3d.com/prusaslicer/ > > > LICENSE= AGPLv3 > > > LICENSE_FILE= ${WRKSRC}/LICENSE > > > > > > +BROKEN= fails to build, error: no member named > 'prior' in > > > namespace 'boost' > > > + > > > > > > > Can we revert this? > > It is an issue with math/cgal and not cad/PrusaSlicer ( > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277480) > > > > Cheers. > > > > > > > > > BUILD_DEPENDS= cereal>=1.3.0.10:devel/cereal \ > > > cgal>=5.0.2:math/cgal \ > > > opencascade>=7.7.0:cad/opencascade > > > > Hi, > > It breaks Prusaslicer either way? > > https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/errors/PrusaSlicer-2.6.0_8.log I just realized I didn't attach the patch to the PR :S It is attached now. With that patch in math/cgal, cad/PrusaSlicer builds fine. My main point is this. We should mark ports as BROKEN when *they* are broken, not when the dependencies are. Otherwise, if/when the dependency is fixed those ports would remain marked as BROKEN unless someone keeps track of what ports where marked that way because of a flaw in the dependency. There are 9 ports depending on math/cgal.I didn't check if any other ports are broken, but any port that includes the same header from math/cgal will fail to build unless they also include boost/next_prior.hpp by any chance The patch in the PR should be upstreamed too and/or math/cgal. > > > Best regards, > Daniel > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 6, 2024 at 10:34 PM Daniel Engberg <<a href="mailto:daniel.engberg.lists@pyret.net">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2024-03-04T18:34:16.000+01:00, Fernando Apesteguía <<a href="mailto:fernando.apesteguia@gmail.com" target="_blank">fernando.apesteguia@gmail.com</a>> wrote:<br> > On Sun, Mar 3, 2024 at 8:36 PM Daniel Engberg <<a href="mailto:diizzy@freebsd.org" target="_blank">diizzy@freebsd.org</a>> wrote:<br> > <br> > <br> > > The branch main has been updated by diizzy:<br> > > <br> > > URL:<br> > > <a href="https://cgit.FreeBSD.org/ports/commit/?id=ea45a9a534994a1bf97a162168902cebbca1f4c1" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=ea45a9a534994a1bf97a162168902cebbca1f4c1</a><br>; > > <br> > > commit ea45a9a534994a1bf97a162168902cebbca1f4c1<br> > > Author: Daniel Engberg <diizzy@FreeBSD.org><br> > > AuthorDate: 2024-03-03 08:29:04 +0000<br> > > Commit: Daniel Engberg <diizzy@FreeBSD.org><br> > > CommitDate: 2024-03-03 19:26:10 +0000<br> > > <br> > > cad/PrusaSlicer: Mark BROKEN<br> > > <br> > > Fails to build, error: no member named 'prior' in namespace 'boost'<br> > > <br> > > Reported by: pkg-fallout<br> > > ---<br> > > cad/PrusaSlicer/Makefile | 2 ++<br> > > 1 file changed, 2 insertions(+)<br> > > <br> > > diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile<br> > > index dc125244df20..936e76216daf 100644<br> > > --- a/cad/PrusaSlicer/Makefile<br> > > +++ b/cad/PrusaSlicer/Makefile<br> > > @@ -12,6 +12,8 @@ WWW= <a href="https://www.prusa3d.com/prusaslicer/" rel="noreferrer" target="_blank">https://www.prusa3d.com/prusaslicer/</a><br>; > > LICENSE= AGPLv3<br> > > LICENSE_FILE= ${WRKSRC}/LICENSE<br> > > <br> > > +BROKEN= fails to build, error: no member named 'prior' in<br> > > namespace 'boost'<br> > > +<br> > > <br> > <br> > Can we revert this?<br> > It is an issue with math/cgal and not cad/PrusaSlicer (<br> > <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277480" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277480</a>) <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > <br> > Cheers.<br> > <br> > <br> > <br> > > BUILD_DEPENDS= cereal&gt;=1.3.0.10:devel/cereal \<br> > > cgal&gt;=5.0.2:math/cgal \<br> > > opencascade&gt;=7.7.0:cad/opencascade<br> > <br> <br> Hi,<br> <br> It breaks Prusaslicer either way?<br> <a href="https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/errors/PrusaSlicer-2.6.0_8.log" rel="noreferrer" target="_blank">https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/errors/PrusaSlicer-2.6.0_8.log</a></blockquote><div><br></div><div>I just realized I didn't attach the patch to the PR :S</div><div>It is attached now.<br></div><div>With that patch in math/cgal, cad/PrusaSlicer builds fine.</div><div><br></div><div>My main point is this. We should mark ports as BROKEN when *they* are broken, not when the dependencies are.</div><div>Otherwise, if/when the dependency is fixed those ports would remain marked as BROKEN unless someone keeps track of what ports where marked that way because of a flaw in the dependency.</div><div>There are 9 ports depending on math/cgal.I didn't check if any other ports are broken, but any port that includes the same header from math/cgal will fail to build unless they also include boost/next_prior.hpp by any chance</div><div> </div><div>The patch in the PR should be upstreamed too and/or math/cgal.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> <br> Best regards,<br> Daniel<br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2adJ-rES4gpgj-4s8dmHEmrtzRZp%2B%2BmJPYs-LueR3piJQ>