Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 7 May 2018 07:30:40 +0000 (UTC)
From:      Emmanuel Vadot <manu@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r333318 - head/sys/dev/extres/clk
Message-ID:  <201805070730.w477Ue88072656@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: manu
Date: Mon May  7 07:30:40 2018
New Revision: 333318
URL: https://svnweb.freebsd.org/changeset/base/333318

Log:
  clk: Add support for assigned-clock-rates
  
  The properties 'assigned-clocks', 'assigned-clock-parents' and
  'assigned-clock-rates' all work together.
  'assigned-clocks' holds the list of clock for which we need to either
  assign a new parent or a new frequency.
  The old code just supported assigning a new parents, add support for
  assigning a new frequency too.

Modified:
  head/sys/dev/extres/clk/clk.c

Modified: head/sys/dev/extres/clk/clk.c
==============================================================================
--- head/sys/dev/extres/clk/clk.c	Mon May  7 07:29:48 2018	(r333317)
+++ head/sys/dev/extres/clk/clk.c	Mon May  7 07:30:40 2018	(r333318)
@@ -1265,43 +1265,95 @@ clk_get_by_id(device_t dev, struct clkdom *clkdom, int
 
 #ifdef FDT
 
+static void
+clk_set_assigned_parent(device_t dev, clk_t clk, int idx)
+{
+	clk_t parent;
+	const char *pname;
+	int rv;
+
+	rv = clk_get_by_ofw_index_prop(dev, 0,
+	    "assigned-clock-parents", idx, &parent);
+	if (rv != 0) {
+		device_printf(dev,
+		    "cannot get parent at idx %d\n", idx);
+		return;
+	}
+
+	pname = clk_get_name(parent);
+	rv = clk_set_parent_by_clk(clk, parent);
+	if (rv != 0)
+		device_printf(dev,
+		    "Cannot set parent %s for clock %s\n",
+		    pname, clk_get_name(clk));
+	else if (bootverbose)
+		device_printf(dev, "Set %s as the parent of %s\n",
+		    pname, clk_get_name(clk));
+	clk_release(parent);
+}
+
+static void
+clk_set_assigned_rates(device_t dev, clk_t clk, uint32_t freq)
+{
+	int rv;
+
+	rv = clk_set_freq(clk, freq, 0);
+	if (rv != 0) {
+		device_printf(dev, "Failed to set %s to a frequency of %u\n",
+		    clk_get_name(clk), freq);
+		return;
+	}
+	if (bootverbose)
+		device_printf(dev, "Set %s to %u\n",
+		    clk_get_name(clk), freq);
+}
+
 int
 clk_set_assigned(device_t dev, phandle_t node)
 {
-	clk_t clk, clk_parent;
-	int error, nclocks, i;
+	clk_t clk;
+	uint32_t *rates;
+	int rv, nclocks, nrates, nparents, i;
 
-	error = ofw_bus_parse_xref_list_get_length(node,
-	    "assigned-clock-parents", "#clock-cells", &nclocks);
+	rv = ofw_bus_parse_xref_list_get_length(node,
+	    "assigned-clocks", "#clock-cells", &nclocks);
 
-	if (error != 0) {
-		if (error != ENOENT)
+	if (rv != 0) {
+		if (rv != ENOENT)
 			device_printf(dev,
-			    "cannot parse assigned-clock-parents property\n");
-		return (error);
+			    "cannot parse assigned-clock property\n");
+		return (rv);
 	}
 
-	for (i = 0; i < nclocks; i++) {
-		error = clk_get_by_ofw_index_prop(dev, 0,
-		    "assigned-clock-parents", i, &clk_parent);
-		if (error != 0) {
-			device_printf(dev, "cannot get parent %d\n", i);
-			return (error);
-		}
+	nrates = OF_getencprop_alloc_multi(node, "assigned-clock-rates",
+	    sizeof(*rates), (void **)&rates);
+	if (nrates <= 0)
+		nrates = 0;
 
-		error = clk_get_by_ofw_index_prop(dev, 0, "assigned-clocks",
+	nparents = ofw_bus_parse_xref_list_get_length(node,
+	    "assigned-clock-parents", "#clock-cells", &nparents);
+
+	for (i = 0; i < nclocks; i++) {
+		/* First get the clock we are supposed to modify */
+		rv = clk_get_by_ofw_index_prop(dev, 0, "assigned-clocks",
 		    i, &clk);
-		if (error != 0) {
-			device_printf(dev, "cannot get assigned clock %d\n", i);
-			clk_release(clk_parent);
-			return (error);
+		if (rv != 0) {
+			if (bootverbose)
+				device_printf(dev,
+				    "cannot get assigned clock at idx %d\n",
+				    i);
+			continue;
 		}
 
-		error = clk_set_parent_by_clk(clk, clk_parent);
-		clk_release(clk_parent);
+		/* First set it's parent if needed */
+		if (i <= nparents)
+			clk_set_assigned_parent(dev, clk, i);
+
+		/* Then set a new frequency */
+		if (i <= nrates)
+			clk_set_assigned_rates(dev, clk, rates[i]);
+
 		clk_release(clk);
-		if (error != 0)
-			return (error);
 	}
 
 	return (0);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805070730.w477Ue88072656>