Date: Sat, 11 Jan 2003 19:22:49 +0100 (CET) From: Tomas Pluskal <plusik@pohoda.cz> To: Bruce Evans <bde@zeta.org.au> Cc: Terry Lambert <tlambert2@mindspring.com>, <freebsd-fs@FreeBSD.ORG> Subject: Re: seeking help to rewrite the msdos filesystem Message-ID: <20030111191832.B18312-200000@localhost.localdomain> In-Reply-To: <20021114020947.O6495-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-2122945715-1042309369=:18312 Content-Type: TEXT/PLAIN; charset=US-ASCII Hello, I have made a simple patch to enable clustering in msdosfs. It is against 4-STABLE. With this patch I get speed on my ZIP drive about 700KB/s (while before it was about 80KB/s). Could please someone review it ? Thanks Tomas On Thu, 14 Nov 2002, Bruce Evans wrote: > On Wed, 13 Nov 2002, Tomas Pluskal wrote: > > > > ... Clustering increases the > > > effective block size to 64K, which is large enough for most purposes, > > > but mdosfs is missing the few lines of code needed to implement > > > clustering... > > > > Could you please write a liitle more about those "missing few > > lines of code" ? I think it is what I could do and what would help when > > using ZIP drives and digital cameras etc.. > > "grep -i cluster *.c" in code for other file systems. cd9660 is simplest -- > it just has one cluster_read() instead of a bread(). > > Bruce > > --0-2122945715-1042309369=:18312 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="msdosfs.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20030111192249.N18312@localhost.localdomain> Content-Description: Content-Disposition: attachment; filename="msdosfs.patch" LS0tIG1zZG9zZnNfdm5vcHMuYy5vbGQJU2F0IEphbiAxMSAxODo1ODoyOCAy MDAzDQorKysgbXNkb3Nmc192bm9wcy5jCVNhdCBKYW4gMTEgMTg6NTg6MzMg MjAwMw0KQEAgLTYwNiwxNCArNjA2LDI0IEBADQogCQl9IGVsc2Ugew0KIAkJ CWJsc2l6ZSA9IHBtcC0+cG1fYnBjbHVzdGVyOw0KIAkJCXJhYmxvY2sgPSBs Ym4gKyAxOw0KLQkJCWlmIChzZXFjb3VudCA+IDEgJiYNCi0JCQkgICAgZGVf Y24yb2ZmKHBtcCwgcmFibG9jaykgPCBkZXAtPmRlX0ZpbGVTaXplKSB7DQot CQkJCXJhc2l6ZSA9IHBtcC0+cG1fYnBjbHVzdGVyOw0KLQkJCQllcnJvciA9 IGJyZWFkbih2cCwgbGJuLCBibHNpemUsDQotCQkJCSAgICAmcmFibG9jaywg JnJhc2l6ZSwgMSwgTk9DUkVELCAmYnApOyANCi0JCQl9IGVsc2Ugew0KLQkJ CQllcnJvciA9IGJyZWFkKHZwLCBsYm4sIGJsc2l6ZSwgTk9DUkVELCAmYnAp Ow0KLQkJCX0NCisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoKHZwLT52 X21vdW50LT5tbnRfZmxhZyAmIE1OVF9OT0NMVVNURVJSKSA9PSAwKSB7DQor ICAgICAgICAJCQlpZiAoZGVfY24yb2ZmKHBtcCwgcmFibG9jaykgPCBkZXAt PmRlX0ZpbGVTaXplKSB7DQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZXJyb3IgPSBjbHVzdGVyX3JlYWQodnAsIChvZmZfdClkZXAt PmRlX0ZpbGVTaXplLA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbGJuLCBibHNpemUsIE5PQ1JFRCwgdWlvLT51aW9f cmVzaWQsDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzZXFjb3VudCAsJmJwKTsNCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIH0gZWxzZSANCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZXJyb3IgPSBicmVhZCh2cCwgbGJuLCBibHNp emUsIE5PQ1JFRCwgJmJwKTsNCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIA0KKyAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7DQor CQkJCWlmIChzZXFjb3VudCA+IDEgJiYNCisJCQkJICAgIGRlX2NuMm9mZihw bXAsIHJhYmxvY2spIDwgZGVwLT5kZV9GaWxlU2l6ZSkgew0KKwkJCQkJcmFz aXplID0gcG1wLT5wbV9icGNsdXN0ZXI7DQorCQkJCQllcnJvciA9IGJyZWFk bih2cCwgbGJuLCBibHNpemUsDQorCQkJCQkJICAgICAgICZyYWJsb2NrLCAm cmFzaXplLCAxLCBOT0NSRUQsICZicCk7IA0KKwkJCQl9IGVsc2Ugew0KKwkJ CQkJZXJyb3IgPSBicmVhZCh2cCwgbGJuLCBibHNpemUsIE5PQ1JFRCwgJmJw KTsNCisJICAgIAkJCX0NCisgICAgICAgICAgICAgICAgICAgICAgICB9DQog CQl9DQogCQlpZiAoZXJyb3IpIHsNCiAJCQlicmVsc2UoYnApOw0KQEAgLTY2 NSw2ICs2NzUsNyBAQA0KIAlzdHJ1Y3QgZGVub2RlICpkZXAgPSBWVE9ERSh2 cCk7DQogCXN0cnVjdCBtc2Rvc2ZzbW91bnQgKnBtcCA9IGRlcC0+ZGVfcG1w Ow0KIAlzdHJ1Y3QgdWNyZWQgKmNyZWQgPSBhcC0+YV9jcmVkOw0KKyAgICAg ICAgaW50IHNlcWNvdW50ID0gYXAtPmFfaW9mbGFnID4+IDE2Ow0KIA0KICNp ZmRlZiBNU0RPU0ZTX0RFQlVHDQogCXByaW50ZigibXNkb3Nmc193cml0ZSh2 cCAlcCwgdWlvICVwLCBpb2ZsYWcgJXgsIGNyZWQgJXBcbiIsDQpAQCAtODEy LDEwICs4MjMsMTcgQEANCiAJCSAqLw0KIAkJaWYgKGlvZmxhZyAmIElPX1NZ TkMpDQogCQkJKHZvaWQpIGJ3cml0ZShicCk7DQotCQllbHNlIGlmIChuICsg Y3JvZmZzZXQgPT0gcG1wLT5wbV9icGNsdXN0ZXIpDQotCQkJYmF3cml0ZShi cCk7DQotCQllbHNlDQorCQllbHNlIGlmIChuICsgY3JvZmZzZXQgPT0gcG1w LT5wbV9icGNsdXN0ZXIpIHsNCisgICAgICAgICAgICAgICAgICAgICAgICBp ZiAoKHZwLT52X21vdW50LT5tbnRfZmxhZyAmIE1OVF9OT0NMVVNURVJXKSA9 PSAwKSB7DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicC0+ Yl9mbGFncyB8PSBCX0NMVVNURVJPSzsNCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNsdXN0ZXJfd3JpdGUoYnAsIGRlcC0+ZGVfRmlsZVNp emUsIHNlcWNvdW50KTsNCisgICAgICAgICAgICAgICAgICAgICAgICB9IGVs c2UgeyAgICANCisgICAgICAgIAkJCWJhd3JpdGUoYnApOw0KKyAgICAgICAg ICAgICAgICAgICAgICAgIH0NCisJCX0gZWxzZSB7DQorICAgICAgICAgICAg ICAgICAgICAgICAgYnAtPmJfZmxhZ3MgfD0gQl9DTFVTVEVST0s7DQogCQkJ YmR3cml0ZShicCk7DQorICAgICAgICAgICAgICAgIH0NCiAJCWRlcC0+ZGVf ZmxhZyB8PSBERV9VUERBVEU7DQogCX0gd2hpbGUgKGVycm9yID09IDAgJiYg dWlvLT51aW9fcmVzaWQgPiAwKTsNCiANCkBAIC0xODA0LDE2ICsxODIyLDI0 IEBADQogCX0gKi8gKmFwOw0KIHsNCiAJc3RydWN0IGRlbm9kZSAqZGVwID0g VlRPREUoYXAtPmFfdnApOw0KKyAgICAgICAgc3RydWN0IG1zZG9zZnNtb3Vu dCAqcG1wID0gZGVwLT5kZV9wbXA7DQorICAgICAgICBkYWRkcl90IGxibGtu byA9IGFwLT5hX2JuOw0KKwlpbnQgYnNoaWZ0ID0gcG1wLT5wbV9ibnNoaWZ0 Ow0KIA0KIAlpZiAoYXAtPmFfdnBwICE9IE5VTEwpDQogCQkqYXAtPmFfdnBw ID0gZGVwLT5kZV9kZXZ2cDsNCiAJaWYgKGFwLT5hX2JucCA9PSBOVUxMKQ0K IAkJcmV0dXJuICgwKTsNCiAJaWYgKGFwLT5hX3J1bnApIHsNCi0JCS8qDQot CQkgKiBTZXF1ZW50aWFsIGNsdXN0ZXJzIHNob3VsZCBiZSBjb3VudGVkIGhl cmUuDQotCQkgKi8NCi0JCSphcC0+YV9ydW5wID0gMDsNCisJCWludCBuYmxr Ow0KKw0KKwkJbmJsayA9IChkZXAtPmRlX0ZpbGVTaXplID4+IGJzaGlmdCkg LSAobGJsa25vICsgMSk7DQorCQlpZiAobmJsayA8PSAwKQ0KKwkJCSphcC0+ YV9ydW5wID0gMDsNCisJCWVsc2UgaWYgKG5ibGsgPj0gKE1BWEJTSVpFID4+ IGJzaGlmdCkpDQorCQkJKmFwLT5hX3J1bnAgPSAoTUFYQlNJWkUgPj4gYnNo aWZ0KSAtIDE7DQorCQllbHNlDQorCQkJKmFwLT5hX3J1bnAgPSBuYmxrOw0K IAl9DQogCWlmIChhcC0+YV9ydW5iKSB7DQogCQkqYXAtPmFfcnVuYiA9IDA7 DQo= --0-2122945715-1042309369=:18312-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030111191832.B18312-200000>