Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 24 Jun 2024 22:43:45 +0200
From:      tuexen@fh-muenster.de
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        Mark Johnston <markj@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: ac52fa1f1b97 - main - sendfile tests: Fix an error check in tcp_socketpair()
Message-ID:  <7054D728-6F4F-4265-ACBB-5DEB94525114@fh-muenster.de>
In-Reply-To: <ZnnRa1CpedgnLKq1@cell.glebi.us>
References:  <202406211821.45LILvWH052581@gitrepo.freebsd.org> <ZnnRa1CpedgnLKq1@cell.glebi.us>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
> On 24. Jun 2024, at 22:04, Gleb Smirnoff <glebius@FreeBSD.org> wrote:
> 
>  Mark,
> 
> On Fri, Jun 21, 2024 at 06:21:57PM +0000, Mark Johnston wrote:
> M> commit ac52fa1f1b9768d281b9deed6d1158f43a8564ca
> M> Author:     Mark Johnston <markj@FreeBSD.org>
> M> AuthorDate: 2024-06-21 18:18:22 +0000
> M> Commit:     Mark Johnston <markj@FreeBSD.org>
> M> CommitDate: 2024-06-21 18:18:22 +0000
> M> 
> M>     sendfile tests: Fix an error check in tcp_socketpair()
> M>     
> M>     Fixes:  c368d3f20fc0 ("tests/sendfile: factor out tcp_socketpair()")
> M>     Differential Revision:  https://reviews.freebsd.org/D45598
> M> ---
> M>  tests/sys/kern/sendfile_helper.c | 2 +-
> M>  1 file changed, 1 insertion(+), 1 deletion(-)
> M> 
> M> diff --git a/tests/sys/kern/sendfile_helper.c b/tests/sys/kern/sendfile_helper.c
> M> index 703b04fdea6c..6365531e312c 100644
> M> --- a/tests/sys/kern/sendfile_helper.c
> M> +++ b/tests/sys/kern/sendfile_helper.c
> M> @@ -84,7 +84,7 @@ tcp_socketpair(int *sv)
> M>   if (fcntl(sv[0], F_SETFL, flags) == -1)
> M>   err(1, "fcntl +O_NONBLOCK");
> M>  
> M> - if (connect(sv[0], (void *)&sin, sizeof(sin)) != -1 ||
> M> + if (connect(sv[0], (void *)&sin, sizeof(sin)) == -1 &&
> M>      errno != EINPROGRESS)
> M>   err(1, "connect cs");
> 
> Sorry for not reviewing in a timely manner. Did you actually observe connect(2)
> on a non-blocking TCP socket to immediately return success?
As far as I know, this can happen.

Best regards
Michael
> 
> -- 
> Gleb Smirnoff


[-- Attachment #2 --]
0	*H
010
	`He0	*H
00	%ف0
	*H
010	UDE1+0)U
"T-Systems Enterprise Services GmbH10UT-Systems Trust Center1%0#UT-TeleSec GlobalRoot Class 20
160222133822Z
310222235959Z010	UDE1E0CU
<Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10UDFN-PKI1-0+U$DFN-Verein Certification Authority 20"0
	*H
0
`fAsMg9Z`GNWKVlUvFEc>pԫT#7(	]Ę7 fxJ2)y T_Jx4twMYZ/l<5e
2mZjKb84YE6Ixjm[k<q;gz6N)=Q\4
u9i%=+;U*^3	1FkYt0p0U0U2&JJK0U#0Y 6y"kaҸ,˂J0U003U ,0*0
+!,0
+!,0g0LUE0C0A?=;http://pki0336.telesec.de/rl/TeleSec_GlobalRoot_Class_2.crl0+z0x0,+0 http://ocsp0336.telesec.de/ocspr0H+0<http://pki0336.telesec.de/crt/TeleSec_GlobalRoot_Class_2.cer0
	*H
>eV-;qOں)!F.8y8tv]bL3j2,LG`Utk,ykMPf0"rM>[ϙR9.D~i;u;"lGG4}=wMOY>GJXoB.M<I&6,"͋xU;DRiТSW{$Jer900c,=0
	*H
010	UDE1E0CU
<Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10UDFN-PKI1-0+U$DFN-Verein Certification Authority 20
160524113840Z
310222235959Z010	UDE1E0CU
<Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10UDFN-PKI1%0#UDFN-Verein Global Issuing CA0"0
	*H
0
;yGi9٢0r)_KhLk{-n:WQ6pmc.@уLf=di囤rh9QyӮ/]cqK9zBi@p翞MGH_e*I-?T/:W~xJA}S_ȳ*0$?MR6$eǖs$hYv~
x<K7S:8Gmd=<ZEJʀ|LL00U00U0)U "0 0
+!,0
+!,0Uk:S୲2	;t0U#02&JJK0U00@><:http://cdp1.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0@><:http://cdp2.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0J+0>http://cdp1.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0J+0>http://cdp2.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0
	*H
xENU	j>xh5?k8w,>̨͠3$b6LxnPn`OR1CFubnfQB1gPI9˟ʆHK+f8W-L_>\)9l{F8ܰ?q3Hc%%<z{Wn8︠/[Kl=w3Sv&%Ao/|~`]AaI)ب-uJU4"0)0&BґA7?0
	*H
010	UDE1E0CU
<Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10UDFN-PKI1%0#UDFN-Verein Global Issuing CA0
220530132215Z
250529132215Z010	UDE10UNordrhein-Westfalen10UMuenster10U
FH Muenster1200U)Fachbereich Elektrotechnik und Informatik10
UTuexen10U*Michael10UMichael Tuexen0"0
	*H
0
{R}HI'ϻYĩhx+C4P"Ty)PRwVf>1{Bak
eĜ~<6?cym,md
3nDzX
l}$v#dij1Jb鴽/;&޸
"n6er8vʝgKVq}c1ｖ<;i8BU~X,s|tٯߨ{1H\EfvzZ؆M/t$1"Q$Usמ>ׅ*fߗqVzwz2졈l7])
&f'c	>ڒ'veV)뛿=a/zd!$6m~v<;B?<=(ӂzT9.#{_aJEP=ɽxO5mtZq9KHAE1Iٵud[WK!*-wNN0J0>U 7050
+!,0+!,
0+!,
0	U00U0U%0++0UPD:~WEǴ(q0U#0k:S୲2	;t0 U0tuexen@fh-muenster.de0U00?=;9http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0?=;9http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0I+0=http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0I+0=http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0
	*H
./xĬNuӌ.-|2RzPtR4`]`OɡX,
լUDZP}4?U+ς`v<[7*;j.!8Y{ߣGIV8[xᲒ)*MZX1銘~4kr90@Yۜmy~?Q];2+ܩ̹b0IU0YW{;aU
k100010	UDE1E0CU
<Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10UDFN-PKI1%0#UDFN-Verein Global Issuing CA&BґA7?0
	`He0	*H
	1	*H
0	*H
	1
240624204345Z0/	*H
	1" b50ٮi&B!ڮ/b0	+710010	UDE1E0CU
<Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10UDFN-PKI1%0#UDFN-Verein Global Issuing CA&BґA7?0*H
	1010	UDE1E0CU
<Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10UDFN-PKI1%0#UDFN-Verein Global Issuing CA&BґA7?0
	*H
B`̨@h़!sd6Ih\ǂD^W>.&NTy|h'A0xy] %\Xx̛EΊx5_tPtpǼrgA
A"*dWoVnN!
"9@,QqCLWjzzgoј1ſNV8:#p8{`;4Nwh:a\3nB;\lz^-Z!CrlX^?sVX3Ev7$OnQyԝaNj=mv+MNa2イ66!]SCȗ}TN{)!D$=!Pv|t5ə3<4Q	ڶF%#HR>2kF0|Q6]QMw&᪌b.L$
ub˝b5V/Ytc'h@T$vCj{
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7054D728-6F4F-4265-ACBB-5DEB94525114>