Date: Sun, 25 Feb 2007 21:38:46 -0500 From: Kurt Miller <lists@intricatesoftware.com> To: freebsd-java@freebsd.org Subject: Re: patch: fix and re-enable curthread hash lookup Message-ID: <200702252138.46660.lists@intricatesoftware.com> In-Reply-To: <Pine.LNX.4.62.0702222353520.12961@decibel.pvv.ntnu.no> References: <Pine.LNX.4.62.0702222353520.12961@decibel.pvv.ntnu.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 22 February 2007 6:10 pm, Arne H. Juul wrote: > I've analyzed the currently disabled code that implements a faster method > to find the current (Java) thread object by getting hold of the stack > pointer and doing a lookup in a hash table. This used to fail on thread > exit sometimes because the invalidation wasn't done properly; I've also > changed some of the parameters for the hash code and upped the size of the > hash table so it should be more optimal. > > Finally I've added a "near hit" feature that should make the lookup faster > when a thread is crossing back and forth over a stack page boundary; > earlier this would always trigger the slow path, but now it compares the > current stack pointer with the low and high stack boundaries and gets a > hit if the hash table entry still points at the right thread object. > > This patch is still experimental, so if people can take a look at it and > tell me about any problems they can spot that would be much appreciated. > > - Arne H. J. Hi, I tried to apply the diff but all parts were rejected. Can you send this again in unified format? I don't mind applying it manually but I only grock unified diffs. :-) -Kurt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702252138.46660.lists>