Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Jul 2016 18:55:54 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   [Bug 211201] print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code
Message-ID:  <bug-211201-6497-0nJZ7iFMtu@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-211201-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-211201-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211201

--- Comment #27 from Jan Beich <jbeich@FreeBSD.org> ---
Comment on attachment 172904
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172904
Proposed patch (since 412348 revision)

> +.include <bsd.port.pre.mk>
> +
> +.if defined(SUBPIXEL_HINTING_MODE)
> +CFLAGS+=3D	-DTT_CONFIG_OPTION_SUBPIXEL_HINTING=3D${SUBPIXEL_HINTING_MODE=
:ts|:Q}

bsd.port.pre.mk can also be dropped via :D modifier.

  CFLAGS+=3D=20=20=20=20=20
${SUBPIXEL_HINTING_MODE:D-DTT_CONFIG_OPTION_SUBPIXEL_HINTING=3D${SUBPIXEL_H=
INTING_MODE:ts|:Q}}

As the line abused horizontal space comment 23 went with option helpers ins=
tead
and a side effect of duplicated CFLAGS. Those are harmless but can still be
fixed by :u modifier.

  .include <bsd.port.options.mk>

  CFLAGS:=3D      ${CFLAGS:u}

I'm sure there're better ways to utilize bmake features in ports but let's =
not
forget that FreeBSD 9.x still use fmake where :ts and :D are not supported.

  $ make
  Unknown modifier 't'

One way to plan for the future EOL (circa 2017-01-01) is to introduce .if
defined(.PARSEDIR) conditionals.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211201-6497-0nJZ7iFMtu>