Date: Tue, 3 Mar 2026 11:41:39 -0700 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c47cefba8312 - main - Only build USB-related modules if MK_USB != no Message-ID: <CANCZdfpZFAZLNf7QhT0SLRX3=CM7aoFUcf4=Ois%2B37w5VED_mA@mail.gmail.com> In-Reply-To: <1s9oq316-3q4o-9273-3qos-3n3o793ns725@mnoonqbm.arg> References: <69a668aa.3785e.4a16f236@gitrepo.freebsd.org> <1s9oq316-3q4o-9273-3qos-3n3o793ns725@mnoonqbm.arg>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Mar 3, 2026 at 11:29 AM Bjoern A. Zeeb <bz@freebsd.org> wrote: > On Tue, 3 Mar 2026, Enji Cooper wrote: > > > The branch main has been updated by ngie: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=c47cefba831240a1b3de375f18134b93cf998f5c > > > > commit c47cefba831240a1b3de375f18134b93cf998f5c > > Author: Enji Cooper <ngie@FreeBSD.org> > > AuthorDate: 2026-03-03 04:49:54 +0000 > > Commit: Enji Cooper <ngie@FreeBSD.org> > > CommitDate: 2026-03-03 04:50:03 +0000 > > > > Only build USB-related modules if MK_USB != no > > > > This change moves the thunderbolt module and other USB modules under a > > MK_USB != no conditional to ensure that users not desiring USB support > > can easily build systems without USB-specific drivers using this knob. > > > > MFC after: 1 week > > Reviewed By: imp > > Differential Revision: https://reviews.freebsd.org/D55576 > > --- > > sys/conf/kern.opts.mk | 5 +++++ > > sys/conf/kmod.mk | 8 ++++++-- > > sys/modules/Makefile | 16 ++++++++++------ > > 3 files changed, 21 insertions(+), 8 deletions(-) > > There is a hige load of further devices which depend on USB which are not > part of the current set excluded; I assume they will now break with > dependency > issues if USB is no longer built but these modules are built. > > Is there any plan to also "hide" all the other modules? > As I said in my review, I'm generally uneasy about this trend... Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Tue, Mar 3, 2026 at 11:29 AM Bjoern A. Zeeb <<a href="mailto:bz@freebsd.org">bz@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, 3 Mar 2026, Enji Cooper wrote:<br> <br> > The branch main has been updated by ngie:<br> ><br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=c47cefba831240a1b3de375f18134b93cf998f5c" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=c47cefba831240a1b3de375f18134b93cf998f5c</a><br>; ><br> > commit c47cefba831240a1b3de375f18134b93cf998f5c<br> > Author: Enji Cooper <ngie@FreeBSD.org><br> > AuthorDate: 2026-03-03 04:49:54 +0000<br> > Commit: Enji Cooper <ngie@FreeBSD.org><br> > CommitDate: 2026-03-03 04:50:03 +0000<br> ><br> > Only build USB-related modules if MK_USB != no<br> ><br> > This change moves the thunderbolt module and other USB modules under a<br> > MK_USB != no conditional to ensure that users not desiring USB support<br> > can easily build systems without USB-specific drivers using this knob.<br> ><br> > MFC after: 1 week<br> > Reviewed By: imp<br> > Differential Revision: <a href="https://reviews.freebsd.org/D55576" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D55576</a><br>; > ---<br> > sys/conf/<a href="http://kern.opts.mk" rel="noreferrer" target="_blank">kern.opts.mk</a> | 5 +++++<br> > sys/conf/<a href="http://kmod.mk" rel="noreferrer" target="_blank">kmod.mk</a> | 8 ++++++--<br> > sys/modules/Makefile | 16 ++++++++++------<br> > 3 files changed, 21 insertions(+), 8 deletions(-)<br> <br> There is a hige load of further devices which depend on USB which are not<br> part of the current set excluded; I assume they will now break with dependency<br> issues if USB is no longer built but these modules are built.<br> <br> Is there any plan to also "hide" all the other modules?<br></blockquote><div><br></div><div>As I said in my review, I'm generally uneasy about this trend...</div><div><br></div><div>Warner</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpZFAZLNf7QhT0SLRX3=CM7aoFUcf4=Ois%2B37w5VED_mA>