Date: Mon, 18 Nov 2013 16:09:00 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, David C Somayajulu <davidcs@FreeBSD.org> Subject: Re: svn commit: r258155 - head/sys/dev/qlxgbe Message-ID: <20131118160900.GB75555@FreeBSD.org> In-Reply-To: <1384786523.31172.467.camel@revolution.hippie.lan> References: <201311150126.rAF1QPZq077225@svn.freebsd.org> <20131118142226.GA52991@FreeBSD.org> <1384786523.31172.467.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 18, 2013 at 07:55:23AM -0700, Ian Lepore wrote: > On Mon, 2013-11-18 at 14:22 +0000, Alexey Dokuchaev wrote: > > On Fri, Nov 15, 2013 at 01:26:25AM +0000, David C Somayajulu wrote: > > > Submitted by:David C Somayajulu > > > > "Submitted by" tag is redundant when submitter == committer. In these > > cases, it simply clutters the log rather than adds anything useful. > > Not always. I put myself in Submitted By when I'm committing a patch > from a PR I filed years ago before I was a committer (sadly there are > enough of these that it's not a thing that just happened once). Even in this case, reference to the PR alone already does the job. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131118160900.GB75555>