Date: Mon, 30 May 2005 14:14:02 +0300 From: Maxim Sobolev <sobomax@portaone.com> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libstand Makefile Message-ID: <429AF57A.5060902@portaone.com> In-Reply-To: <20050530104131.GB54585@ip.net.ua> References: <200505292105.j4TL5w32038570@repoman.freebsd.org> <20050530104131.GB54585@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote:
> Hi,
>
> On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote:
>
>>sobomax 2005-05-29 21:05:58 UTC
>>
>> FreeBSD src repository
>>
>> Modified files:
>> lib/libstand Makefile
>> Log:
>> Add missed ${.CURDIR}/../../contrib/bzip2 into include search path, otherwise
>> old version of bzlib.h can be picked up from the /usr/include.
>>
>> Revision Changes Path
>> 1.51 +1 -1 src/lib/libstand/Makefile
>>
>
> Changes like this, while harmless, unnecessarily pollute makefiles.
> During buildworld we first install new headers then build new
> libraries then the rest. When doing standalone compiles, the same
> procedure should generally be followed. (Otherwise, you'd end up
> changing every utility's makefile that uses libstand to add this
> -I to CFLAGS.)
This is incorrect assertion since libstand hides implementation details,
so that it is not necessary to include bzlib.h into code which uses
libstand.
> I have only problem with the above change: it has a wrong attribution
> in the commit log. The correct commit log would be: "aid in lazy
> standalone builds by always picking up a fresh copy of bzlib.h from
> sources".
-Maxim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?429AF57A.5060902>