Date: Wed, 21 Jan 2015 02:08:54 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Willem Jan Withagen <wjw@digiware.nl> Cc: Benjamin Perrault <ben.perrault@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org>, Will Andrews <will@FreeBSD.org> Subject: Re: Head not buildin in zfs.c Message-ID: <F78E49DF-8AB7-4330-8963-D287627612CA@gmail.com> In-Reply-To: <54BF79E1.3060401@digiware.nl> References: <54BF72A9.5000608@digiware.nl> <31627BCE-2B7A-44AA-9442-2D9347C1F571@gmail.com> <54BF79E1.3060401@digiware.nl>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Jan 21, 2015, at 2:05, Willem Jan Withagen <wjw@digiware.nl> wrote:
> On 2015-01-21 10:51, Benjamin Perrault wrote:
>>
>>> On Jan 21, 2015, at 1:34 AM, Willem Jan Withagen <wjw@digiware.nl>
>>> wrote:
>>>
>>>
>>> Found this lastnight build. Just fetched the most recent HEAD.
>>> Error remains
>>>
>>> --- zfs/zfs.o --- In file included from
>>> /usr/srcs/src11/src/lib/libprocstat/zfs/../zfs.c:39:
>>> /usr/srcs/src11/src/lib/libprocstat/zfs/../../../cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h:538:9:
>>> error: 'NSEC_TO_TICK' macro redefined [-Werror,-Wmacro-redefined]
>>> #define NSEC_TO_TICK(usec) ((usec) / (NANOSEC / hz)) ^
>>> /usr/srcs/src11/src/lib/libprocstat/zfs/../../../sys/cddl/compat/opensolaris/sys/time.h:54:9:
>>> note: previous definition is here #define NSEC_TO_TICK(nsec)
>>> ((nsec) / (NANOSEC / hz)) ^ /etc/{make,src}.conf are empty
>>>
>
>> I’m seeing the exact same issue. It began for me at r277472 and is
>> still persisting as of r277482 ( the most recent HEAD as of writing
>> this email ).
>
> Well, the problem is reported several times during compilation.
> This is the first warning that also has -Werror, and hence building stops.
>
> I have not been able to find where this -Werror "all of a sudden" pops up.
>
> Has to be in any of those commits...
It’s a mismatch in the macro definitions, made in the commit below.
I’m testing out a fix for it right now.
Thanks for the report!
------------------------------------------------------------------------
r277449 | will | 2015-01-20 14:29:27 -0800 (Tue, 20 Jan 2015) | 2 lines
NSEC_TO_TICK(usec) -> NSEC_TO_TICK(nsec)
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJUv3q2AAoJEMZr5QU6S73e22QH/2GvMa6XZ89HqwbPz8+y0mHu
m/CVTijTCzvrXH9ECQuTr6oV7k1VMap1I5PMsbeqnaZyVrM6dDL3PhlMpVDuq1rF
lhOQIIjrkWMROR4wa4XYaaJWq8HByILXFL5+iquEmDFvSWkM+5UnF4NCm1FvAq4D
Q54Xni/cITbLDs+Mj7wEeNCtPYF6QnoMDrfoxyn9/nyqaAuZTBfWJ6b0IQBnYb1o
a4zPURG41LKaNsGwcRbJyPQXRvEotWHKuCo/jOff+BsG5i+u29Il605KsLiPXXkO
QFIGll60FSslCK9E1SBxpKqnJa8GyUDxWxPoI+3y8GMy4k2DjK2lh8CFmW4OOPI=
=X8nr
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F78E49DF-8AB7-4330-8963-D287627612CA>