Date: Mon, 28 Jun 2004 02:21:53 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: pav@FreeBSD.org Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/math/gnuplot Makefile Message-ID: <28186290-C899-11D8-9FE1-00039312D914@fillmore-labs.com> In-Reply-To: <1088380914.969.10.camel@hood.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
Pav Lucistnik wrote: > In the unattended build, when no OPTIONS dialog is displayed, you don't > have any WITH* and WITHOUT* variables set. Your port should behave as if > default values were selected. > > OPTIONS= OPTION "foo" on > > Default is to have OPTION on. When no WITH/WITHOUT* variables are > generated, your test > > .if defined(WITH_OPTION) > > will fail. That's now the default you wanted. If you check instead > > .if !defined(WITHOUT_OPTION) > > it will work correctly in case OPTIONS were not processed. This nicely > demonstrates in unattended build on packages on Bento, for example. As a side note, generously changing WITH_* to WITHOUT_* breaks upgrading for all people (like me) that use portupgrade to upgrade their ports. Also, it might be intended to have a different set of options preselected to choose from than those used for package building. You should note changes like this at least in UPDATING. -Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?28186290-C899-11D8-9FE1-00039312D914>