Date: Mon, 5 May 2003 11:14:39 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: Philippe Charnier <charnier@xp11.frmug.org> Cc: jhb@FreeBSD.org Subject: Re: panic: mutex process lock not owned at ../../../kern/sys_process.c:97 Message-ID: <Pine.NEB.3.96L.1030505111413.24722U-100000@fledge.watson.org> In-Reply-To: <200305041908.h44J84wu000743@xp11.frmug.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 4 May 2003, Philippe Charnier wrote:
> Robert Watson <rwatson@FreeBSD.org> wrote:
>
> >> 80 if (kl < 0)
> >> 81 error = EINVAL;
> >> 82 else
> >> 83 /* XXXKSE: */
> >> 84 error = proc_read_regs(FIRST_THREAD_IN_PROC(p), &r);
> >> 85 if (error == 0)
> >> 86 error = uiomove(kv, kl, uio);
> >> 87 PROC_LOCK(p);
> >> 88 if (error == 0 && uio->uio_rw == UIO_WRITE) {
> >
> >Try moving the PROC_UNLOCK() call from line 79 to just after line 84
> >(i.e., before the error check and possible uiomove()). It looks like some
> >similar bugs might exist in other bits of procfs.
>
> With your patch applied, the kernel does not panic anymore.
> Thanks
Ok, I've committed the fix following John's review. Please let us know if
anything else like this turns up.
Thanks!
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Network Associates Laboratories
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1030505111413.24722U-100000>