Date: Mon, 15 Jan 2001 11:28:24 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: SXren Schmidt <sos@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/ata ata-all.c Message-ID: <XFMail.010115112824.jhb@FreeBSD.org> In-Reply-To: <200101141936.f0EJaKM70546@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14-Jan-01 SXren Schmidt wrote: > sos 2001/01/14 11:36:20 PST > > Modified files: > sys/dev/ata ata-all.c > Log: > Use prober atomic operations when test&set'ing ->active. > > This turns some of my lockups under SMP into spontanious reboots... Erm, all of this should be running under Giant, so you shouldn't be contending on this. You should probably protect this with a mutex that locks the softc rather than using atomic operations, btw. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010115112824.jhb>