Date: Wed, 21 Oct 2015 12:43:20 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203923] Coverity CID 975621: False positive Message-ID: <bug-203923-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203923 Bug ID: 203923 Summary: Coverity CID 975621: False positive Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/cd9660/cd9660_write.c CID 975621 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR) copy_paste_error: rf in fclose(rf) looks like a copy-paste error. Should it say fd instead? 471 (void)fclose(rf); --------------- Source analysis: The suspicion stems from the assymetric reaction on error. Only the read FILE pointer rf was opened inside the function. So it gets closed in both error cases: with read FILE *rf and with write FILE *fd. if (ferror(rf)) { ... (void)fclose(rf); ... if (ferror(fd)) { ... (void)fclose(rf); --------------- Remedy proposal: In Coverity classify CID 975621 as "False positive" and set its Action to "Ignore". -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203923-8>