Date: Tue, 23 Aug 2011 17:10:41 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: Hiroki Sato <hrs@FreeBSD.org>, current@FreeBSD.org, Benjamin Kaduk <kaduk@MIT.EDU> Subject: Re: fsid change of ZFS? Message-ID: <20110823151041.GA1697@garage.freebsd.pl> In-Reply-To: <1965813445.219973.1314108581091.JavaMail.root@erie.cs.uoguelph.ca> References: <20110823113044.GB1662@garage.freebsd.pl> <1965813445.219973.1314108581091.JavaMail.root@erie.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Aug 23, 2011 at 10:09:41AM -0400, Rick Macklem wrote: > Ok, I'll admit I wasn't very fond of a fixed table that would inevitably > get out of date someday, either. > > I didn't think hashing for the cases not in the table was worth the effort, > but doing a hash instead of a table seems reasonable. > > I see that ZFS only uses the low order 8 bits, so I'll try and come up > with an 8bit hash solution and will post a patch for testing/review soon. > > I don't think the vfs_sysctl() is that great a concern, given that it > appears to be deprecated already anyhow. (With an 8bit hash, vfs_typenum > won't be that sparse.) I'll also make sure that whatever hash I use > doesn't collide for the current list of file names (although I will include > code that handles a collision in the patch). Sounds great. Thanks! -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk5TwvAACgkQForvXbEpPzSfFwCfWLYfd7U0G+7LtaEeZCLcwG0o u84AoIzRC53xtqSEeH9MK7MdAd5QsWbg =/73t -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110823151041.GA1697>