Date: Sun, 10 Nov 2019 14:55:19 -0500 From: Viktor Dukhovni <ietf-dane@dukhovni.org> To: freebsd-haskell@freebsd.org, haskell@freebsd.org Subject: Re: FYI: Opened GHC PRs to add missing include of sys/types.h Message-ID: <20191110195519.GQ34850@straasha.imrryr.org> In-Reply-To: <CALH631kbOa3PYV7y8D1HaO_CRm-4CLwH3QV_xYo23zWYeNiZ7w@mail.gmail.com> References: <20191110192729.GP34850@straasha.imrryr.org> <CALH631kbOa3PYV7y8D1HaO_CRm-4CLwH3QV_xYo23zWYeNiZ7w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 10, 2019 at 11:39:09PM +0400, Gleb Popov wrote: > > Once > > > > https://gitlab.haskell.org/ghc/ghc/merge_requests/2132 > > https://gitlab.haskell.org/ghc/ghc/merge_requests/2133 > > https://gitlab.haskell.org/ghc/ghc/merge_requests/2134 > > > > are merged, there will no longer be a need to apply a patch to > > libraries/base/dist-install/build/System/Environment/ExecutablePath.hsc > > to create "bindists" or any future ports for GHC 8.8.2 and beyond. > > Great, thanks for submitting this upstream. While at it, maybe you'll be > interested in upstreaming https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241849 ? In fact I'm already looking at it, indeed this is what got me energized enough to submit the sys/time.h fixes upstream, but I first want to test the proposed fix a bit more. At a minimum, the condition for enabling the pthread codepath likely needs to be: #if defined(freebsd_HOST_OS) && defined(THREADED_RTS) rather than just: #if defined(freebsd_HOST_OS) which mimmics the Linux variant: #if defined(linux_HOST_OS) && defined(THREADED_RTS) && HAVE_SYS_TIMERFD_H #define USE_PTHREAD_FOR_ITIMER #endif -- Viktor.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191110195519.GQ34850>