Date: Fri, 28 Feb 2025 21:48:35 +0100 From: Daniel Engberg <diizzy@FreeBSD.org> To: Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: d73350357635 - main - archivers/zstd: Update to 1.5.7 Message-ID: <1c5311a8-ebcf-4d8a-9211-e6852eba1c64@FreeBSD.org> In-Reply-To: <202502281052.51SAqPiQ037511@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2025-02-28 11:52, Po-Chuan Hsieh wrote: > The branch main has been updated by sunpoet: > > URL:https://cgit.FreeBSD.org/ports/commit/?id=d73350357635c97b7484fc2d355c1191ebfcb83f > > commit d73350357635c97b7484fc2d355c1191ebfcb83f > Author: Po-Chuan Hsieh<sunpoet@FreeBSD.org> > AuthorDate: 2025-02-28 10:34:16 +0000 > Commit: Po-Chuan Hsieh<sunpoet@FreeBSD.org> > CommitDate: 2025-02-28 10:34:16 +0000 > > archivers/zstd: Update to 1.5.7 > > Changes:https://github.com/facebook/zstd/releases > --- > archivers/zstd/Makefile | 4 ++-- > archivers/zstd/distinfo | 6 +++--- > archivers/zstd/files/zstdConfigVersion.cmake.in | 13 ------------- > 3 files changed, 5 insertions(+), 18 deletions(-) > > diff --git a/archivers/zstd/Makefile b/archivers/zstd/Makefile > index 64ac16833c83..f8c954f78eaa 100644 > --- a/archivers/zstd/Makefile > +++ b/archivers/zstd/Makefile > @@ -1,5 +1,5 @@ > PORTNAME= zstd > -PORTVERSION= 1.5.6 > +PORTVERSION= 1.5.7 > CATEGORIES= archivers > MASTER_SITES= https://github.com/facebook/zstd/releases/download/v${PORTVERSION}/ > > @@ -26,7 +26,7 @@ MAKE_ENV= INSTALL_DATA="${INSTALL_DATA}" \ > INSTALL_SCRIPT="${INSTALL_SCRIPT}" \ > MANDIR=${PREFIX}/share/man \ > V=1 > -TEST_TARGET= shortest > +TEST_TARGET= check > USE_LDCONFIG= yes > > PLIST_SUB= BUILD_TYPE=${BUILD_TYPE:tl} PORTVERSION=${PORTVERSION} > diff --git a/archivers/zstd/distinfo b/archivers/zstd/distinfo > index 46a55033cd34..06fcc91f806d 100644 > --- a/archivers/zstd/distinfo > +++ b/archivers/zstd/distinfo > @@ -1,3 +1,3 @@ > -TIMESTAMP = 1711540146 > -SHA256 (zstd-1.5.6.tar.zst) = 4aa8dd1c1115c0fd6b6b66c35c7f6ce7bd58cc1dfd3e4f175b45b39e84b14352 > -SIZE (zstd-1.5.6.tar.zst) = 1845516 > +TIMESTAMP = 1740022434 > +SHA256 (zstd-1.5.7.tar.zst) = 5b331d961d6989dc21bb03397fc7a2a4d86bc65a14adc5ffbbce050354e30fd2 > +SIZE (zstd-1.5.7.tar.zst) = 1862563 > diff --git a/archivers/zstd/files/zstdConfigVersion.cmake.in b/archivers/zstd/files/zstdConfigVersion.cmake.in > index 4528f77accac..aca8084b9b16 100644 > --- a/archivers/zstd/files/zstdConfigVersion.cmake.in > +++ b/archivers/zstd/files/zstdConfigVersion.cmake.in > @@ -50,16 +50,3 @@ else() > endif() > endif() > endif() > - > - > -# if the installed or the using project don't have CMAKE_SIZEOF_VOID_P set, ignore it: > -if("${CMAKE_SIZEOF_VOID_P}" STREQUAL "" OR "8" STREQUAL "") > - return() > -endif() > - > -# check that the installed version has the same 32/64bit-ness as the one which is currently searching: > -if(NOT CMAKE_SIZEOF_VOID_P STREQUAL "8") > - math(EXPR installedBits "8 * 8") > - set(PACKAGE_VERSION "${PACKAGE_VERSION} (${installedBits}bit)") > - set(PACKAGE_VERSION_UNSUITABLE TRUE) > -endif() Hi, This installs broken and incorrect man page(s) because you're missing upstream commit 6af3842118ea5325480b403213b2a9fbed3d3d74 Any specific reason as to why we're not adopting CMake like other distros (see PR) instead of having the current "hack"? CPE entry/string is missing PR 284957 roughly a week ago Best regards, Daniel [-- Attachment #2 --] <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">On 2025-02-28 11:52, Po-Chuan Hsieh wrote:<br> </div> <blockquote type="cite" cite="mid:202502281052.51SAqPiQ037511@gitrepo.freebsd.org"> <pre wrap="" class="moz-quote-pre">The branch main has been updated by sunpoet: URL: <a class="moz-txt-link-freetext" href="https://cgit.FreeBSD.org/ports/commit/?id=d73350357635c97b7484fc2d355c1191ebfcb83f">https://cgit.FreeBSD.org/ports/commit/?id=d73350357635c97b7484fc2d355c1191ebfcb83f</a>; commit d73350357635c97b7484fc2d355c1191ebfcb83f Author: Po-Chuan Hsieh <a class="moz-txt-link-rfc2396E" href="mailto:sunpoet@FreeBSD.org"><sunpoet@FreeBSD.org></a> AuthorDate: 2025-02-28 10:34:16 +0000 Commit: Po-Chuan Hsieh <a class="moz-txt-link-rfc2396E" href="mailto:sunpoet@FreeBSD.org"><sunpoet@FreeBSD.org></a> CommitDate: 2025-02-28 10:34:16 +0000 archivers/zstd: Update to 1.5.7 Changes: <a class="moz-txt-link-freetext" href="https://github.com/facebook/zstd/releases">https://github.com/facebook/zstd/releases</a>; --- archivers/zstd/Makefile | 4 ++-- archivers/zstd/distinfo | 6 +++--- archivers/zstd/files/zstdConfigVersion.cmake.in | 13 ------------- 3 files changed, 5 insertions(+), 18 deletions(-) diff --git a/archivers/zstd/Makefile b/archivers/zstd/Makefile index 64ac16833c83..f8c954f78eaa 100644 --- a/archivers/zstd/Makefile +++ b/archivers/zstd/Makefile @@ -1,5 +1,5 @@ PORTNAME= zstd -PORTVERSION= 1.5.6 +PORTVERSION= 1.5.7 CATEGORIES= archivers MASTER_SITES= <a class="moz-txt-link-freetext" href="https://github.com/facebook/zstd/releases/download/v$">https://github.com/facebook/zstd/releases/download/v$</a>{PORTVERSION}/ @@ -26,7 +26,7 @@ MAKE_ENV= INSTALL_DATA="${INSTALL_DATA}" \ INSTALL_SCRIPT="${INSTALL_SCRIPT}" \ MANDIR=${PREFIX}/share/man \ V=1 -TEST_TARGET= shortest +TEST_TARGET= check USE_LDCONFIG= yes PLIST_SUB= BUILD_TYPE=${BUILD_TYPE:tl} PORTVERSION=${PORTVERSION} diff --git a/archivers/zstd/distinfo b/archivers/zstd/distinfo index 46a55033cd34..06fcc91f806d 100644 --- a/archivers/zstd/distinfo +++ b/archivers/zstd/distinfo @@ -1,3 +1,3 @@ -TIMESTAMP = 1711540146 -SHA256 (zstd-1.5.6.tar.zst) = 4aa8dd1c1115c0fd6b6b66c35c7f6ce7bd58cc1dfd3e4f175b45b39e84b14352 -SIZE (zstd-1.5.6.tar.zst) = 1845516 +TIMESTAMP = 1740022434 +SHA256 (zstd-1.5.7.tar.zst) = 5b331d961d6989dc21bb03397fc7a2a4d86bc65a14adc5ffbbce050354e30fd2 +SIZE (zstd-1.5.7.tar.zst) = 1862563 diff --git a/archivers/zstd/files/zstdConfigVersion.cmake.in b/archivers/zstd/files/zstdConfigVersion.cmake.in index 4528f77accac..aca8084b9b16 100644 --- a/archivers/zstd/files/zstdConfigVersion.cmake.in +++ b/archivers/zstd/files/zstdConfigVersion.cmake.in @@ -50,16 +50,3 @@ else() endif() endif() endif() - - -# if the installed or the using project don't have CMAKE_SIZEOF_VOID_P set, ignore it: -if("${CMAKE_SIZEOF_VOID_P}" STREQUAL "" OR "8" STREQUAL "") - return() -endif() - -# check that the installed version has the same 32/64bit-ness as the one which is currently searching: -if(NOT CMAKE_SIZEOF_VOID_P STREQUAL "8") - math(EXPR installedBits "8 * 8") - set(PACKAGE_VERSION "${PACKAGE_VERSION} (${installedBits}bit)") - set(PACKAGE_VERSION_UNSUITABLE TRUE) -endif()</pre> </blockquote> <p>Hi,</p> <p>This installs broken and incorrect man page(s) because you're missing upstream commit 6af3842118ea5325480b403213b2a9fbed3d3d74</p> <p>Any specific reason as to why we're not adopting CMake like other distros (see PR) instead of having the current "hack"?</p> <p>CPE entry/string is missing</p> <p>PR 284957 roughly a week ago</p> <p>Best regards,</p> <p>Daniel<br> </p> <p><span style="white-space: pre-wrap"> </span></p> </body> </html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1c5311a8-ebcf-4d8a-9211-e6852eba1c64>