Date: Thu, 12 Aug 1999 16:05:01 +0200 From: Anton Berezin <tobez@plab.ku.dk> To: Tim Vanderhoek <vanderh@ecf.utoronto.ca> Cc: Bill Fumerola <billf@jade.chc-chimes.com>, freebsd-ports@FreeBSD.ORG Subject: Re: ports/13030: Many ports use ``chown'' rather than ``/usr/sbin/chown'' in their Makefiles Message-ID: <19990812160501.B57548@lion.plab.ku.dk> In-Reply-To: <19990812093835.A44972@mad>; from Tim Vanderhoek on Thu, Aug 12, 1999 at 09:38:35AM -0400 References: <19990809083649.B97354@mad> <Pine.BSF.4.10.9908090901570.72927-100000@jade.chc-chimes.com> <19990812125750.B56987@lion.plab.ku.dk> <19990812093835.A44972@mad>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 12, 1999 at 09:38:35AM -0400, Tim Vanderhoek wrote:
> > # skip clever CHOWN assignments - they are unnecessary
> > next if m%^\s*CHOWN\s*\??=\s*(?:/usr/sbin/)?chown\s*$%;
>
> The script should probably bleat if it sees this.
I don't think so. There are some ports which do that, and it *is* safe
to remove the line. Or leave it as it is, alternatively - in most cases
it is just CHOWN?=... Anyway, it is very easy to catch those - a single
``- line'' in unidiff is always alarming. :-)
> > # change all /usr/sbin/chown for ${CHOWN}
> > s%/usr/sbin/chown%\${CHOWN}%g;
>
> Better add \s+ to the start of that, just to be safe. Shouldn't make
No! Consider @/usr/sbin/chown - there are plenty of these.
> a difference, but consider linux_base, which does somethign like
> ${PREFIX}/sbin/ldconfig. Such an instance should be left hardcoded.
Probably just [^}] then?
Cheers,
--
Anton Berezin <tobez@plab.ku.dk>
The Protein Laboratory, University of Copenhagen
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990812160501.B57548>